Re: [Xen-devel] [PATCH] x86emul: also put_fpu() on error paths

2015-05-15 Thread Andrew Cooper
On 15/05/15 13:37, Jan Beulich wrote: > fail_if() and generate_exception_if() could theoretically bypass the > normal flow reaching put_fpu(), and not invoking it would leave the > fpu_exception_callback pointer in place, allowing for the callback to > be called at an unexpected time. Luckily the t

[Xen-devel] [PATCH] x86emul: also put_fpu() on error paths

2015-05-15 Thread Jan Beulich
fail_if() and generate_exception_if() could theoretically bypass the normal flow reaching put_fpu(), and not invoking it would leave the fpu_exception_callback pointer in place, allowing for the callback to be called at an unexpected time. Luckily the two generate_exception_if()-s that would actual