Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-05 Thread Andrew Cooper
On 05/09/16 10:51, Jan Beulich wrote: On 05.09.16 at 11:43, wrote: >> On 05/09/16 07:32, Jan Beulich wrote: >> On 02.09.16 at 17:14, wrote: On 01/09/16 16:27, Jan Beulich wrote: >>> +{ >>> +if ( d->arch.x86_vendor == X86_VENDOR_AMD ) >>> +

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-05 Thread Jan Beulich
>>> On 05.09.16 at 11:43, wrote: > On 05/09/16 07:32, Jan Beulich wrote: > On 02.09.16 at 17:14, wrote: >>> On 01/09/16 16:27, Jan Beulich wrote: >> +{ >> +if ( d->arch.x86_vendor == X86_VENDOR_AMD ) >> +{ >> +*eax = 0; >> +

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-05 Thread Andrew Cooper
On 05/09/16 07:32, Jan Beulich wrote: On 02.09.16 at 17:14, wrote: >> On 01/09/16 16:27, Jan Beulich wrote: > +{ > +if ( d->arch.x86_vendor == X86_VENDOR_AMD ) > +{ > +*eax = 0; > +*ebx = 0; > +

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-04 Thread Jan Beulich
>>> On 02.09.16 at 17:14, wrote: > On 01/09/16 16:27, Jan Beulich wrote: >> +{ +if ( d->arch.x86_vendor == X86_VENDOR_AMD ) +{ +*eax = 0; +*ebx = 0; +*ecx = 0; +*edx =

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-02 Thread Andrew Cooper
On 01/09/16 16:27, Jan Beulich wrote: > >>> +{ >>> +if ( d->arch.x86_vendor == X86_VENDOR_AMD ) >>> +{ >>> +*eax = 0; >>> +*ebx = 0; >>> +*ecx = 0; >>> +*edx = 0; >>> +return; >>> +

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-01 Thread Jan Beulich
>>> On 01.09.16 at 16:27, wrote: > On 24/08/16 16:31, Jan Beulich wrote: >> Another place where we should try to behave like real hardware; see >> the code comments. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -3358,6 +3358,31 @@ void

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-01 Thread Andrew Cooper
On 24/08/16 16:31, Jan Beulich wrote: > Another place where we should try to behave like real hardware; see > the code comments. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -3358,6 +3358,31 @@ void hvm_cpuid(unsigned int input, unsig > i

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-01 Thread Andrew Cooper
On 01/09/16 13:56, Jan Beulich wrote: On 01.09.16 at 13:23, wrote: >> On 24/08/16 16:31, Jan Beulich wrote: >>> Another place where we should try to behave like real hardware; see >>> the code comments. >>> >>> Signed-off-by: Jan Beulich >>> >>> --- a/xen/arch/x86/hvm/hvm.c >>> +++ b/xen/arc

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-01 Thread Jan Beulich
>>> On 01.09.16 at 13:23, wrote: > On 24/08/16 16:31, Jan Beulich wrote: >> Another place where we should try to behave like real hardware; see >> the code comments. >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -3358,6 +3358,31 @@ void

Re: [Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-09-01 Thread Andrew Cooper
On 24/08/16 16:31, Jan Beulich wrote: > Another place where we should try to behave like real hardware; see > the code comments. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -3358,6 +3358,31 @@ void hvm_cpuid(unsigned int input, unsig > i

[Xen-devel] [PATCH] x86: correct CPUID output for out of bounds input

2016-08-24 Thread Jan Beulich
Another place where we should try to behave like real hardware; see the code comments. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -3358,6 +3358,31 @@ void hvm_cpuid(unsigned int input, unsig if ( !edx ) edx = &dummy; +if ( input &