Re: [Xen-devel] [PATCH] x86/vmx: Improvements to vmentry failure handling

2015-10-29 Thread Jan Beulich
>>> On 23.10.15 at 19:52, wrote: > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -1588,21 +1588,14 @@ void vmx_destroy_vmcs(struct vcpu *v) > free_xenheap_page(v->arch.hvm_vmx.msr_bitmap); > } > > -void vm_launch_fail(void) > -{ > -unsigned long error; > -

Re: [Xen-devel] [PATCH] x86/vmx: Improvements to vmentry failure handling

2015-10-28 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Saturday, October 24, 2015 1:53 AM > > Combine the almost identical vm_launch_fail() and vm_resume_fail() into > a single vmx_vmentry_failure(). > > Re-save all GPRs so that domain_crash() prints the real register values, > rather t

[Xen-devel] [PATCH] x86/vmx: Improvements to vmentry failure handling

2015-10-23 Thread Andrew Cooper
Combine the almost identical vm_launch_fail() and vm_resume_fail() into a single vmx_vmentry_failure(). Re-save all GPRs so that domain_crash() prints the real register values, rather than the active stack of the vmx_vmentry_failure() callpath. Signed-off-by: Andrew Cooper --- CC: Jan Beulich C