Re: [Xen-devel] [PATCH] x86/traps: Misc tweaks to several printk()s

2015-07-15 Thread Jan Beulich
>>> On 15.07.15 at 11:48, wrote: > On 15/07/15 10:03, Jan Beulich wrote: > On 14.07.15 at 19:54, wrote: >>> @@ -626,8 +626,9 @@ static void do_trap(struct cpu_user_regs *regs, int > use_error_code) >>> >>> if ( likely((fixup = search_exception_table(regs->eip)) != 0) ) >>> { >>>

Re: [Xen-devel] [PATCH] x86/traps: Misc tweaks to several printk()s

2015-07-15 Thread Andrew Cooper
On 15/07/15 10:03, Jan Beulich wrote: On 14.07.15 at 19:54, wrote: >> @@ -626,8 +626,9 @@ static void do_trap(struct cpu_user_regs *regs, int >> use_error_code) >> >> if ( likely((fixup = search_exception_table(regs->eip)) != 0) ) >> { >> -dprintk(XENLOG_ERR, "Trap %d: %p

Re: [Xen-devel] [PATCH] x86/traps: Misc tweaks to several printk()s

2015-07-15 Thread Jan Beulich
>>> On 14.07.15 at 19:54, wrote: > @@ -626,8 +626,9 @@ static void do_trap(struct cpu_user_regs *regs, int > use_error_code) > > if ( likely((fixup = search_exception_table(regs->eip)) != 0) ) > { > -dprintk(XENLOG_ERR, "Trap %d: %p -> %p\n", > -trapnr, _p(regs

[Xen-devel] [PATCH] x86/traps: Misc tweaks to several printk()s

2015-07-14 Thread Andrew Cooper
* Reword the printk() in do_guest_trap() to avoid "Unhandled general protection fault fault/trap" * Drop irrelevant file/line references. * Make some of the text more concise. * A trap with an extable entry does not warrant an error level message. * Use %ps for extable sources to provide extra