Re: [Xen-devel] [PATCH] x86/traps: Avoid the #GP slowpath for guest #DB exceptions

2015-01-09 Thread Andrew Cooper
On 08/01/15 14:00, Jan Beulich wrote: On 08.01.15 at 14:25, wrote: >> do_debug() is capable of correctly dealing with #DB exceptions in guest >> context, and indeed needs to be as the 'icebp' instruction skips the DPL >> check anyway. > I don't follow: ICEBP doesn't check DPL, right, but what

Re: [Xen-devel] [PATCH] x86/traps: Avoid the #GP slowpath for guest #DB exceptions

2015-01-08 Thread Jan Beulich
>>> On 08.01.15 at 14:25, wrote: > do_debug() is capable of correctly dealing with #DB exceptions in guest > context, and indeed needs to be as the 'icebp' instruction skips the DPL > check anyway. I don't follow: ICEBP doesn't check DPL, right, but what does setting DPL to 3 buy us? Other than f

[Xen-devel] [PATCH] x86/traps: Avoid the #GP slowpath for guest #DB exceptions

2015-01-08 Thread Andrew Cooper
do_debug() is capable of correctly dealing with #DB exceptions in guest context, and indeed needs to be as the 'icebp' instruction skips the DPL check anyway. Signed-off-by: Andrew Cooper CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan --- xen/arch/x86/traps.c |2 +- 1 file changed, 1 inse