Re: [Xen-devel] [PATCH] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-09 Thread Andrew Cooper
On 09/02/15 13:26, Jan Beulich wrote: On 09.02.15 at 14:13, wrote: >> On 09/02/15 12:56, Jan Beulich wrote: >>> So wouldn't it be possible to get rid of nmi_crash() and have >>> nmi() call *nmi_handler instead of don_nmi (and nmi_handler >>> would really just become an alias of exception_tabl

Re: [Xen-devel] [PATCH] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-09 Thread Jan Beulich
>>> On 09.02.15 at 14:13, wrote: > On 09/02/15 12:56, Jan Beulich wrote: >> So wouldn't it be possible to get rid of nmi_crash() and have >> nmi() call *nmi_handler instead of don_nmi (and nmi_handler >> would really just become an alias of exception_table[2]? > > nmi_crash() deliberately doesn't

Re: [Xen-devel] [PATCH] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-09 Thread Andrew Cooper
On 09/02/15 12:56, Jan Beulich wrote: On 09.02.15 at 12:52, wrote: >> On 09/02/15 11:43, Tim Deegan wrote: >>> Hi, >>> >>> At 11:25 + on 09 Feb (1423477508), Andrew Cooper wrote: In the case of a crash, nmi_shootdown_cpus() patches nmi_crash() into the >> IDT of each processor,

Re: [Xen-devel] [PATCH] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-09 Thread Jan Beulich
>>> On 09.02.15 at 12:52, wrote: > On 09/02/15 11:43, Tim Deegan wrote: >> Hi, >> >> At 11:25 + on 09 Feb (1423477508), Andrew Cooper wrote: >>> In the case of a crash, nmi_shootdown_cpus() patches nmi_crash() into the > IDT >>> of each processor, such that the next NMI it receives will force

Re: [Xen-devel] [PATCH] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-09 Thread Andrew Cooper
On 09/02/15 11:43, Tim Deegan wrote: > Hi, > > At 11:25 + on 09 Feb (1423477508), Andrew Cooper wrote: >> In the case of a crash, nmi_shootdown_cpus() patches nmi_crash() into the IDT >> of each processor, such that the next NMI it receives will force it into the >> crash path. >> >> c/s 7dd3b0

Re: [Xen-devel] [PATCH] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-09 Thread Tim Deegan
Hi, At 11:25 + on 09 Feb (1423477508), Andrew Cooper wrote: > In the case of a crash, nmi_shootdown_cpus() patches nmi_crash() into the IDT > of each processor, such that the next NMI it receives will force it into the > crash path. > > c/s 7dd3b06ff "vmx: fix handling of NMI VMEXIT" fixed on

[Xen-devel] [PATCH] x86/nmi: Fix shootdown of pcpus running in VMX non-root mode

2015-02-09 Thread Andrew Cooper
In the case of a crash, nmi_shootdown_cpus() patches nmi_crash() into the IDT of each processor, such that the next NMI it receives will force it into the crash path. c/s 7dd3b06ff "vmx: fix handling of NMI VMEXIT" fixed one issue but inadvertently introduced another. The original use of self_nmi