Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-28 Thread Vlad-Ioan TOPAN
On Tue, 21 Mar 2017 12:04:02 + Andrew Cooper wrote: > On 10/03/17 15:50, Vlad Ioan Topan wrote: > > Adds monitor support for descriptor access events (reads & writes of > > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > > > Signed-off-by: Vlad Ioan Topan > > How much extra o

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-21 Thread Andrew Cooper
On 10/03/17 15:50, Vlad Ioan Topan wrote: > Adds monitor support for descriptor access events (reads & writes of > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > Signed-off-by: Vlad Ioan Topan How much extra overhead does this typically give? (I am curious, more than anything els

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-21 Thread Jan Beulich
>>> On 20.03.17 at 20:21, wrote: > On Fri, 17 Mar 2017 05:03:44 -0600 > "Jan Beulich" wrote: >> >>> On 10.03.17 at 16:50, wrote: >> > +else >> > +{ >> > +hvm_emulate_init_once(&ctxt, NULL, guest_cpu_user_regs()); >> > +rc = hvm_emulate_one(&ctxt); >> > +switch ( r

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-20 Thread Vlad-Ioan TOPAN
On Fri, 17 Mar 2017 05:03:44 -0600 "Jan Beulich" wrote: > >>> On 10.03.17 at 16:50, wrote: > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > @@ -3645,6 +3645,41 @@ gp_fault: > > return X86EMUL_EXCEPTION; > > } > > > > +int hvm_descriptor_access_intercept(uint64_t exit

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-17 Thread Jan Beulich
>>> On 10.03.17 at 16:50, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -3645,6 +3645,41 @@ gp_fault: > return X86EMUL_EXCEPTION; > } > > +int hvm_descriptor_access_intercept(uint64_t exit_info, uint64_t > exit_qualification, > +

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-16 Thread Vlad-Ioan TOPAN
On Tue, 14 Mar 2017 09:15:04 -0400 Boris Ostrovsky wrote: > > > On 03/14/2017 08:50 AM, Razvan Cojocaru wrote: > > On 03/14/2017 02:15 PM, Vlad-Ioan TOPAN wrote: > @@ -2642,6 +2660,38 @@ void svm_vmexit_handler(struct cpu_user_regs > *regs) > case VMEXIT_PAUSE: >

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-14 Thread Jan Beulich
>>> On 14.03.17 at 13:15, wrote: >> > @@ -2642,6 +2660,38 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) >> > case VMEXIT_PAUSE: >> > svm_vmexit_do_pause(regs); >> > break; >> > + >> > +case VMEXIT_IDTR_READ: >> > +hvm_descriptor_access_intercept(vmcb

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-14 Thread Boris Ostrovsky
On 03/14/2017 08:50 AM, Razvan Cojocaru wrote: On 03/14/2017 02:15 PM, Vlad-Ioan TOPAN wrote: @@ -2642,6 +2660,38 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) case VMEXIT_PAUSE: svm_vmexit_do_pause(regs); break; + +case VMEXIT_IDTR_READ: +hvm_descri

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-14 Thread Razvan Cojocaru
On 03/14/2017 02:15 PM, Vlad-Ioan TOPAN wrote: >>> @@ -2642,6 +2660,38 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) >>> case VMEXIT_PAUSE: >>> svm_vmexit_do_pause(regs); >>> break; >>> + >>> +case VMEXIT_IDTR_READ: >>> +hvm_descriptor_access_intercep

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-14 Thread Wei Liu
On Fri, Mar 10, 2017 at 05:50:34PM +0200, Vlad Ioan Topan wrote: > Adds monitor support for descriptor access events (reads & writes of > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > Signed-off-by: Vlad Ioan Topan > --- > tools/libxc/include/xenctrl.h | 2 ++ > tools/lib

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-14 Thread Vlad-Ioan TOPAN
> > @@ -2642,6 +2660,38 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) > > case VMEXIT_PAUSE: > > svm_vmexit_do_pause(regs); > > break; > > + > > +case VMEXIT_IDTR_READ: > > +hvm_descriptor_access_intercept(vmcb->exitintinfo.bytes, 0, > > VM_EVENT_DES

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-14 Thread Vlad-Ioan TOPAN
> > +struct vm_event_desc_access { > > +union { > > +uint32_t vmx_instr_info;/* VMX: VMCS Instruction-Information > > Field */ > > +uint64_t svm_exitinfo; /* SVM: VMCB EXITINFO Field */ > > +uint64_t info; > > +} vmexit; > > +uint64_t exit_qualification

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-13 Thread Boris Ostrovsky
> @@ -2642,6 +2660,38 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) > case VMEXIT_PAUSE: > svm_vmexit_do_pause(regs); > break; > + > +case VMEXIT_IDTR_READ: > +hvm_descriptor_access_intercept(vmcb->exitintinfo.bytes, 0, > VM_EVENT_DESC_IDTR, 0); > +

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-10 Thread Tamas K Lengyel
On Fri, Mar 10, 2017 at 8:50 AM, Vlad Ioan Topan wrote: > Adds monitor support for descriptor access events (reads & writes of > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > Signed-off-by: Vlad Ioan Topan > --- > tools/libxc/include/xenctrl.h | 2 ++ > tools/libxc/xc_mon

[Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-10 Thread Vlad Ioan Topan
Adds monitor support for descriptor access events (reads & writes of IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). Signed-off-by: Vlad Ioan Topan --- tools/libxc/include/xenctrl.h | 2 ++ tools/libxc/xc_monitor.c| 14 +++ tools/tests/xen-access/xen-access.