Re: [Xen-devel] [PATCH] x86/monitor: Include EAX/ECX in CPUID monitor events

2016-09-01 Thread Tamas K Lengyel
On Thu, Sep 1, 2016 at 2:02 AM, Razvan Cojocaru wrote: > On 09/01/2016 10:58 AM, Jan Beulich wrote: > On 01.09.16 at 09:26, wrote: >>> On 09/01/16 02:52, Tamas K Lengyel wrote: --- a/xen/include/public/vm_event.h +++ b/xen/include/public/vm_event.h @@ -226,6 +226,13 @@ struct v

Re: [Xen-devel] [PATCH] x86/monitor: Include EAX/ECX in CPUID monitor events

2016-09-01 Thread Tamas K Lengyel
On Thu, Sep 1, 2016 at 2:01 AM, Jan Beulich wrote: On 01.09.16 at 01:52, wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -2402,12 +2402,17 @@ static void vmx_cpuid_intercept( >> static int vmx_do_cpuid(struct cpu_user_regs *regs) >> { >> unsigned i

Re: [Xen-devel] [PATCH] x86/monitor: Include EAX/ECX in CPUID monitor events

2016-09-01 Thread Jan Beulich
>>> On 01.09.16 at 01:52, wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -2402,12 +2402,17 @@ static void vmx_cpuid_intercept( > static int vmx_do_cpuid(struct cpu_user_regs *regs) > { > unsigned int eax, ebx, ecx, edx; > +unsigned int _eax, _ecx; Ple

Re: [Xen-devel] [PATCH] x86/monitor: Include EAX/ECX in CPUID monitor events

2016-09-01 Thread Razvan Cojocaru
On 09/01/2016 10:58 AM, Jan Beulich wrote: On 01.09.16 at 09:26, wrote: >> On 09/01/16 02:52, Tamas K Lengyel wrote: >>> --- a/xen/include/public/vm_event.h >>> +++ b/xen/include/public/vm_event.h >>> @@ -226,6 +226,13 @@ struct vm_event_mov_to_msr { >>> >>> struct vm_event_cpuid { >>>

Re: [Xen-devel] [PATCH] x86/monitor: Include EAX/ECX in CPUID monitor events

2016-09-01 Thread Jan Beulich
>>> On 01.09.16 at 09:26, wrote: > On 09/01/16 02:52, Tamas K Lengyel wrote: >> --- a/xen/include/public/vm_event.h >> +++ b/xen/include/public/vm_event.h >> @@ -226,6 +226,13 @@ struct vm_event_mov_to_msr { >> >> struct vm_event_cpuid { >> uint32_t insn_length; >> +/* >> + * Value

Re: [Xen-devel] [PATCH] x86/monitor: Include EAX/ECX in CPUID monitor events

2016-09-01 Thread Razvan Cojocaru
On 09/01/16 02:52, Tamas K Lengyel wrote: > Extend the CPUID monitor event to include EAX and ECX values that were used > when CPUID was executed. This is useful in identifying which leaf was queried. > We also adjust the xen-access output format to more closely resemble the > output > of the Linu

[Xen-devel] [PATCH] x86/monitor: Include EAX/ECX in CPUID monitor events

2016-08-31 Thread Tamas K Lengyel
Extend the CPUID monitor event to include EAX and ECX values that were used when CPUID was executed. This is useful in identifying which leaf was queried. We also adjust the xen-access output format to more closely resemble the output of the Linux cpuid tool's raw format. Signed-off-by: Tamas K Le