On 19/07/17 15:12, Roger Pau Monné wrote:
> On Wed, Jul 19, 2017 at 02:27:31PM +0100, Andrew Cooper wrote:
>> These functions don't need is_hvm_{vcpu,domain}() predicates.
>>
>> hvmop_set_evtchn_upcall_vector() does need the predicate to prevent a PV
>> caller accessing the hvm union, but swap the
On Wed, Jul 19, 2017 at 02:27:31PM +0100, Andrew Cooper wrote:
> These functions don't need is_hvm_{vcpu,domain}() predicates.
>
> hvmop_set_evtchn_upcall_vector() does need the predicate to prevent a PV
> caller accessing the hvm union, but swap the copy_from_guest() and
> is_hvm_domain() predica
On Wed, Jul 19, 2017 at 02:27:31PM +0100, Andrew Cooper wrote:
> These functions don't need is_hvm_{vcpu,domain}() predicates.
>
> hvmop_set_evtchn_upcall_vector() does need the predicate to prevent a PV
> caller accessing the hvm union, but swap the copy_from_guest() and
> is_hvm_domain() predica
> -Original Message-
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
> Sent: 19 July 2017 14:28
> To: Xen-devel
> Cc: Andrew Cooper ; George Dunlap
> ; Jan Beulich ; Wei Liu
> ; Paul Durrant ; Roger Pau
> Monne
> Subject: [PATCH] x86/hvm: Drop more remains of the PVHv1 implementa
These functions don't need is_hvm_{vcpu,domain}() predicates.
hvmop_set_evtchn_upcall_vector() does need the predicate to prevent a PV
caller accessing the hvm union, but swap the copy_from_guest() and
is_hvm_domain() predicate to avoid reading the hypercall parameter if we not
going to use it.
S
