Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 17:16, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 30 March 2016 15:22 >> To: Paul Durrant >> Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) >> Subject: RE: [PATCH] x86/hvm/viridian: zero and check vcpu contex

Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 March 2016 15:22 > To: Paul Durrant > Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) > Subject: RE: [PATCH] x86/hvm/viridian: zero and check vcpu context __pad > field > > >>> On 30.03.16 at 1

Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 15:19, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 30 March 2016 14:17 >> To: Paul Durrant >> Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) >> Subject: RE: [PATCH] x86/hvm/viridian: zero and check vcpu contex

Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 March 2016 14:17 > To: Paul Durrant > Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) > Subject: RE: [PATCH] x86/hvm/viridian: zero and check vcpu context __pad > field > > >>> On 30.03.16 at 1

Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 13:26, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 30 March 2016 12:23 >> >>> On 30.03.16 at 12:32, wrote: >> > --- a/xen/arch/x86/hvm/viridian.c >> > +++ b/xen/arch/x86/hvm/viridian.c >> > @@ -824,6 +824,8 @@ static int viridian_save_vcpu_ctxt(struct domain

Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 March 2016 12:23 > To: Paul Durrant > Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) > Subject: Re: [PATCH] x86/hvm/viridian: zero and check vcpu context __pad > field > > >>> On 30.03.16 at 1

Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 12:32, wrote: > --- a/xen/arch/x86/hvm/viridian.c > +++ b/xen/arch/x86/hvm/viridian.c > @@ -824,6 +824,8 @@ static int viridian_save_vcpu_ctxt(struct domain *d, > hvm_domain_context_t *h) > for_each_vcpu( d, v ) { > struct hvm_viridian_vcpu_context ctxt; > > +

[Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
Commit 57844631 "save APIC assist vector" added an extra field to the viridian vcpu context save record. This field was only a uint8_t and so an extra __pad field was also added to pad up to the next 64-bit boundary. This patch makes sure that __pad field is zeroed on save and checked for zero on