Re: [Xen-devel] [PATCH] x86/emul: Annotate more intentional fallthrough cases

2016-12-12 Thread Jan Beulich
>>> On 12.12.16 at 11:05, wrote: > @@ -4314,6 +4315,7 @@ x86_emulate( > > case 0xfe: /* Grp4 */ > generate_exception_if((modrm_reg & 7) >= 2, EXC_UD); > +/* Fallthough. */ With the missing r added, Reviewed-by: Jan Beulich Jan __

[Xen-devel] [PATCH] x86/emul: Annotate more intentional fallthrough cases

2016-12-12 Thread Andrew Cooper
Some recent change in x86_emulate.c has simplified the callgraph sufficiently for Coverity to notice these, rather than hitting its upper path limit. All are legitimate fallthoughs. Annotate them as such. Signed-off-by: Andrew Cooper --- CC: Jan Beulich --- xen/arch/x86/x86_emulate/x86_emulat