Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-16 Thread Jan Beulich
>>> On 16.12.16 at 14:57, wrote: > On Thu, Dec 15, 2016 at 07:04:51AM -0700, Jan Beulich wrote: >> Despite all attempts so far (ending in commit fecf584294 ["Config.mk: >> fix comment for debug option"] adjusting the respective comment), >> Config.mk's debug= setting still affects the hypervisor b

Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-16 Thread Wei Liu
On Thu, Dec 15, 2016 at 07:04:51AM -0700, Jan Beulich wrote: > Despite all attempts so far (ending in commit fecf584294 ["Config.mk: > fix comment for debug option"] adjusting the respective comment), > Config.mk's debug= setting still affects the hypervisor build: CFLAGS > gets -g added there. >

Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-16 Thread Daniel Kiper
On Fri, Dec 16, 2016 at 05:38:35AM -0700, Jan Beulich wrote: > >>> On 16.12.16 at 11:33, wrote: > > On Thu, Dec 15, 2016 at 07:04:51AM -0700, Jan Beulich wrote: > >> Despite all attempts so far (ending in commit fecf584294 ["Config.mk: > >> fix comment for debug option"] adjusting the respective c

Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-16 Thread Jan Beulich
>>> On 16.12.16 at 11:33, wrote: > On Thu, Dec 15, 2016 at 07:04:51AM -0700, Jan Beulich wrote: >> Despite all attempts so far (ending in commit fecf584294 ["Config.mk: >> fix comment for debug option"] adjusting the respective comment), >> Config.mk's debug= setting still affects the hypervisor b

Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-16 Thread Daniel Kiper
On Fri, Dec 16, 2016 at 11:33:18AM +0100, Daniel Kiper wrote: > On Thu, Dec 15, 2016 at 07:04:51AM -0700, Jan Beulich wrote: [...] > > --- a/xen/arch/x86/boot/build32.mk > > +++ b/xen/arch/x86/boot/build32.mk > > @@ -4,7 +4,7 @@ include $(XEN_ROOT)/Config.mk > > > > $(call cc-options-add,CFLAGS,

Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-16 Thread Daniel Kiper
On Thu, Dec 15, 2016 at 07:04:51AM -0700, Jan Beulich wrote: > Despite all attempts so far (ending in commit fecf584294 ["Config.mk: > fix comment for debug option"] adjusting the respective comment), > Config.mk's debug= setting still affects the hypervisor build: CFLAGS > gets -g added there. > >

Re: [Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-15 Thread Andrew Cooper
On 15/12/16 14:04, Jan Beulich wrote: > Despite all attempts so far (ending in commit fecf584294 ["Config.mk: > fix comment for debug option"] adjusting the respective comment), > Config.mk's debug= setting still affects the hypervisor build: CFLAGS > gets -g added there. > > xen/arch/x86/boot/buil

[Xen-devel] [PATCH] x86/boot: fix build with certain older gcc versions

2016-12-15 Thread Jan Beulich
Despite all attempts so far (ending in commit fecf584294 ["Config.mk: fix comment for debug option"] adjusting the respective comment), Config.mk's debug= setting still affects the hypervisor build: CFLAGS gets -g added there. xen/arch/x86/boot/build32.mk includes that file, and hence inherits the