Re: [Xen-devel] [PATCH] x86/NUMA: cleanup

2015-10-13 Thread Andrew Cooper
On 13/10/15 13:29, Jan Beulich wrote: > - constification > - prefer container_of() over casts > - check original pointer against NULL instead of the container_of() > result > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mail

[Xen-devel] [PATCH] x86/NUMA: cleanup

2015-10-13 Thread Jan Beulich
- constification - prefer container_of() over casts - check original pointer against NULL instead of the container_of() result Signed-off-by: Jan Beulich --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -205,7 +205,7 @@ void __init acpi_numa_slit_init(struct a /* Callback for Proximit