Re: [Xen-devel] [PATCH] x86/IO-APIC: fix setting of destinations

2015-11-19 Thread Andrew Cooper
On 19/11/15 09:46, Jan Beulich wrote: > In commit a85da715cf ("x86/IO-APIC: adjust setting of destinations") I > made a pretty blatant mistake: get_apic_id() can be used there only > when running APICs in physical mode. For both flat and clustered modes > the change was wrong, causing different kin

Re: [Xen-devel] [PATCH] x86/IO-APIC: fix setting of destinations

2015-11-19 Thread Boris Ostrovsky
On 11/19/2015 04:46 AM, Jan Beulich wrote: In commit a85da715cf ("x86/IO-APIC: adjust setting of destinations") I made a pretty blatant mistake: get_apic_id() can be used there only when running APICs in physical mode. For both flat and clustered modes the change was wrong, causing different kind

[Xen-devel] [PATCH] x86/IO-APIC: fix setting of destinations

2015-11-19 Thread Jan Beulich
In commit a85da715cf ("x86/IO-APIC: adjust setting of destinations") I made a pretty blatant mistake: get_apic_id() can be used there only when running APICs in physical mode. For both flat and clustered modes the change was wrong, causing different kinds of boot problems on affected systems. Don't