Re: [Xen-devel] [PATCH] x86/EFI + Live Patch: avoid symbol address truncation

2016-06-29 Thread Jan Beulich
>>> On 28.06.16 at 19:20, wrote: > On Tue, Jun 28, 2016 at 08:03:57AM -0600, Jan Beulich wrote: >> ld associates __init_end, placed outside of any section by the linker >> script, with the following section, resulting in a huge (wrapped, as it >> would be negative) section relative offset. COFF sy

Re: [Xen-devel] [PATCH] x86/EFI + Live Patch: avoid symbol address truncation

2016-06-28 Thread Konrad Rzeszutek Wilk
On Tue, Jun 28, 2016 at 08:03:57AM -0600, Jan Beulich wrote: > ld associates __init_end, placed outside of any section by the linker > script, with the following section, resulting in a huge (wrapped, as it > would be negative) section relative offset. COFF symbol tables store > section relative ad

Re: [Xen-devel] [PATCH] x86/EFI + Live Patch: avoid symbol address truncation

2016-06-28 Thread Andrew Cooper
On 28/06/16 17:11, Jan Beulich wrote: >>> --- a/xen/arch/x86/xen.lds.S >>> +++ b/xen/arch/x86/xen.lds.S >>> @@ -40,9 +40,20 @@ SECTIONS >>> #if !defined(EFI) >>>. = __XEN_VIRT_START; >>>__image_base__ = .; >>> +#else >>> + . = __image_base__; >>> #endif >>> >>> +#if 0 >>> +/* >>> + * W

Re: [Xen-devel] [PATCH] x86/EFI + Live Patch: avoid symbol address truncation

2016-06-28 Thread Jan Beulich
>>> On 28.06.16 at 16:26, wrote: > On 28/06/16 15:03, Jan Beulich wrote: >> ld associates __init_end, placed outside of any section by the linker >> script, with the following section, resulting in a huge (wrapped, as it >> would be negative) section relative offset. > > So in this case, the caus

Re: [Xen-devel] [PATCH] x86/EFI + Live Patch: avoid symbol address truncation

2016-06-28 Thread Andrew Cooper
On 28/06/16 15:03, Jan Beulich wrote: > ld associates __init_end, placed outside of any section by the linker > script, with the following section, resulting in a huge (wrapped, as it > would be negative) section relative offset. So in this case, the cause of the truncation is due to __init_end be

[Xen-devel] [PATCH] x86/EFI + Live Patch: avoid symbol address truncation

2016-06-28 Thread Jan Beulich
ld associates __init_end, placed outside of any section by the linker script, with the following section, resulting in a huge (wrapped, as it would be negative) section relative offset. COFF symbol tables store section relative addresses, and hence the above leads to assembler truncation warnings w