Re: [Xen-devel] [PATCH] trace: Fix incorrect number of pages used for trace metadata

2016-10-04 Thread Igor Druzhinin
Checked that. Tested-by: Igor Druzhinin On 30/09/16 17:12, George Dunlap wrote: On 30/09/16 17:04, Igor Druzhinin wrote: On 30/09/16 15:46, George Dunlap wrote: On 29/09/16 14:53, Igor Druzhinin wrote: As long as t_info_first_offset is calculated in uint32_t offsets we need to multiply it b

Re: [Xen-devel] [PATCH] trace: Fix incorrect number of pages used for trace metadata

2016-09-30 Thread George Dunlap
On 30/09/16 17:04, Igor Druzhinin wrote: > On 30/09/16 15:46, George Dunlap wrote: >> On 29/09/16 14:53, Igor Druzhinin wrote: >>> As long as t_info_first_offset is calculated in uint32_t offsets we >>> need to >>> multiply it by sizeof(uint32_t) in order to get the right number of >>> pages >>> fo

Re: [Xen-devel] [PATCH] trace: Fix incorrect number of pages used for trace metadata

2016-09-30 Thread Igor Druzhinin
On 30/09/16 15:46, George Dunlap wrote: On 29/09/16 14:53, Igor Druzhinin wrote: As long as t_info_first_offset is calculated in uint32_t offsets we need to multiply it by sizeof(uint32_t) in order to get the right number of pages for trace metadata. Not doing that makes it impossible to read th

Re: [Xen-devel] [PATCH] trace: Fix incorrect number of pages used for trace metadata

2016-09-30 Thread George Dunlap
On 30/09/16 15:46, George Dunlap wrote: > On 29/09/16 14:53, Igor Druzhinin wrote: >> As long as t_info_first_offset is calculated in uint32_t offsets we need to >> multiply it by sizeof(uint32_t) in order to get the right number of pages >> for trace metadata. Not doing that makes it impossible to

Re: [Xen-devel] [PATCH] trace: Fix incorrect number of pages used for trace metadata

2016-09-30 Thread Andrew Cooper
On 30/09/16 15:46, George Dunlap wrote: > On 29/09/16 14:53, Igor Druzhinin wrote: >> > As long as t_info_first_offset is calculated in uint32_t offsets we need to >> > multiply it by sizeof(uint32_t) in order to get the right number of pages >> > for trace metadata. Not doing that makes it impossi

Re: [Xen-devel] [PATCH] trace: Fix incorrect number of pages used for trace metadata

2016-09-30 Thread George Dunlap
On 29/09/16 14:53, Igor Druzhinin wrote: > As long as t_info_first_offset is calculated in uint32_t offsets we need to > multiply it by sizeof(uint32_t) in order to get the right number of pages > for trace metadata. Not doing that makes it impossible to read the trace > buffer correctly from users

[Xen-devel] [PATCH] trace: Fix incorrect number of pages used for trace metadata

2016-09-29 Thread Igor Druzhinin
As long as t_info_first_offset is calculated in uint32_t offsets we need to multiply it by sizeof(uint32_t) in order to get the right number of pages for trace metadata. Not doing that makes it impossible to read the trace buffer correctly from userspace for some corner cases. Signed-off-by: Igor