Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-09 Thread Andrew Cooper
On 09/10/15 05:42, Juergen Gross wrote: > > > Andrew, which of those does your xen_bugtool use? Currently just xc.domain_getinfo() ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-09 Thread Juergen Gross
On 10/09/2015 11:43 AM, Ian Campbell wrote: On Fri, 2015-10-09 at 06:42 +0200, Juergen Gross wrote: Is it okay to remove all of the unused bindings? Please can you remind me what your motivation is here, just cleaning up detritus or are some of these bindings actively hindering work you are d

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-09 Thread Ian Campbell
On Fri, 2015-10-09 at 06:42 +0200, Juergen Gross wrote: > Is it okay to remove all of the unused bindings? Please can you remind me what your motivation is here, just cleaning up detritus or are some of these bindings actively hindering work you are doing? Or are they known to be broken? If it's

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-08 Thread Juergen Gross
On 10/08/2015 06:32 PM, Zhigang Wang wrote: On 10/08/2015 11:27 AM, Ian Campbell wrote: On Thu, 2015-10-08 at 11:09 -0400, Zhigang Wang wrote: On 10/08/2015 10:38 AM, Ian Campbell wrote: On Tue, 2015-10-06 at 11:24 -0400, Zhigang Wang wrote: We use these extentions along with xend XMLRPC API/

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-08 Thread Wei Liu
On Thu, Oct 08, 2015 at 12:32:44PM -0400, Zhigang Wang wrote: > On 10/08/2015 11:27 AM, Ian Campbell wrote: > > On Thu, 2015-10-08 at 11:09 -0400, Zhigang Wang wrote: > >> On 10/08/2015 10:38 AM, Ian Campbell wrote: > >>> On Tue, 2015-10-06 at 11:24 -0400, Zhigang Wang wrote: > We use these ex

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-08 Thread Zhigang Wang
On 10/08/2015 11:27 AM, Ian Campbell wrote: > On Thu, 2015-10-08 at 11:09 -0400, Zhigang Wang wrote: >> On 10/08/2015 10:38 AM, Ian Campbell wrote: >>> On Tue, 2015-10-06 at 11:24 -0400, Zhigang Wang wrote: We use these extentions along with xend XMLRPC API/xm. Even when move to xl,

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-08 Thread Ian Campbell
On Thu, 2015-10-08 at 11:09 -0400, Zhigang Wang wrote: > On 10/08/2015 10:38 AM, Ian Campbell wrote: > > On Tue, 2015-10-06 at 11:24 -0400, Zhigang Wang wrote: > > > We use these extentions along with xend XMLRPC API/xm. Even when move > > > to > > > xl, this will give us a choice to reserve some l

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-08 Thread Zhigang Wang
On 10/08/2015 10:38 AM, Ian Campbell wrote: > On Tue, 2015-10-06 at 11:24 -0400, Zhigang Wang wrote: >> We use these extentions along with xend XMLRPC API/xm. Even when move to >> xl, this will give us a choice to reserve some logic. > > There are a lot of interfaces here, are you using all of the

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-08 Thread Ian Campbell
On Tue, 2015-10-06 at 11:24 -0400, Zhigang Wang wrote: > We use these extentions along with xend XMLRPC API/xm. Even when move to > xl, this will give us a choice to reserve some logic. There are a lot of interfaces here, are you using all of them? If not then could you enumerate the ones you care

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-08 Thread Ian Campbell
On Thu, 2015-10-08 at 06:16 +0200, Juergen Gross wrote: > [0] although we are still waiting for Konrad's reply on that one in > > > the > > > relevant thread. > > > > RIP PV superpages. > > Okay, I'll do this as soon as Roger's domain builder patches are > committed. I think the ones which might

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-07 Thread Juergen Gross
On 10/08/2015 03:10 AM, Konrad Rzeszutek Wilk wrote: On Tue, Oct 06, 2015 at 05:24:22PM +0100, Ian Campbell wrote: On Tue, 2015-10-06 at 18:14 +0200, Juergen Gross wrote: The original motivation was to get rid of the "superpages" option when building a pv-domU. It's suffered rather from feat

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-07 Thread Konrad Rzeszutek Wilk
On Tue, Oct 06, 2015 at 05:24:22PM +0100, Ian Campbell wrote: > On Tue, 2015-10-06 at 18:14 +0200, Juergen Gross wrote: > > > The original motivation was to get rid of the "superpages" option when > > building a pv-domU. > > It's suffered rather from feature creep then, since removing that one >

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Marek Marczykowski-Górecki
On Tue, Oct 06, 2015 at 12:18:50PM +0100, Wei Liu wrote: > On Tue, Oct 06, 2015 at 12:46:08PM +0200, Juergen Gross wrote: > > Remove lots of functions in tools/python/xen/lowlevel/xc/xc.c as they > > are not used anywhere in the tree. In fact only one function is still > > being used from pygrub, n

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Ian Campbell
On Tue, 2015-10-06 at 17:31 +0100, Wei Liu wrote: > On Tue, Oct 06, 2015 at 04:38:08PM +0100, Andrew Cooper wrote: > > On 06/10/15 16:26, Ian Campbell wrote: > > > On Tue, 2015-10-06 at 17:21 +0200, Juergen Gross wrote: > > > > On 10/06/2015 05:11 PM, Ian Campbell wrote: > > > > > On Tue, 2015-10-0

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Wei Liu
On Tue, Oct 06, 2015 at 05:38:42PM +0100, Ian Campbell wrote: > On Tue, 2015-10-06 at 17:31 +0100, Wei Liu wrote: > > On Tue, Oct 06, 2015 at 04:38:08PM +0100, Andrew Cooper wrote: > > > On 06/10/15 16:26, Ian Campbell wrote: > > > > On Tue, 2015-10-06 at 17:21 +0200, Juergen Gross wrote: > > > > >

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Wei Liu
On Tue, Oct 06, 2015 at 04:38:08PM +0100, Andrew Cooper wrote: > On 06/10/15 16:26, Ian Campbell wrote: > > On Tue, 2015-10-06 at 17:21 +0200, Juergen Gross wrote: > >> On 10/06/2015 05:11 PM, Ian Campbell wrote: > >>> On Tue, 2015-10-06 at 16:51 +0200, Juergen Gross wrote: > On 10/06/2015 03:

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Ian Campbell
On Tue, 2015-10-06 at 18:14 +0200, Juergen Gross wrote: > The original motivation was to get rid of the "superpages" option when > building a pv-domU. It's suffered rather from feature creep then, since removing that one interface seems like much less of a problem[0] than a wholesale skewering of

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Juergen Gross
On 10/06/2015 05:45 PM, Ian Campbell wrote: On Tue, 2015-10-06 at 11:30 -0400, Zhigang Wang wrote: On 10/06/2015 11:26 AM, Ian Campbell wrote: On Tue, 2015-10-06 at 17:21 +0200, Juergen Gross wrote: On 10/06/2015 05:11 PM, Ian Campbell wrote: On Tue, 2015-10-06 at 16:51 +0200, Juergen Gross w

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Ian Campbell
On Tue, 2015-10-06 at 11:30 -0400, Zhigang Wang wrote: > On 10/06/2015 11:26 AM, Ian Campbell wrote: > > On Tue, 2015-10-06 at 17:21 +0200, Juergen Gross wrote: > > > On 10/06/2015 05:11 PM, Ian Campbell wrote: > > > > On Tue, 2015-10-06 at 16:51 +0200, Juergen Gross wrote: > > > > > On 10/06/2015

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Andrew Cooper
On 06/10/15 16:26, Ian Campbell wrote: > On Tue, 2015-10-06 at 17:21 +0200, Juergen Gross wrote: >> On 10/06/2015 05:11 PM, Ian Campbell wrote: >>> On Tue, 2015-10-06 at 16:51 +0200, Juergen Gross wrote: On 10/06/2015 03:40 PM, Ian Campbell wrote: > On Tue, 2015-10-06 at 12:39 +0100, Wei L

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Zhigang Wang
On 10/06/2015 11:26 AM, Ian Campbell wrote: > On Tue, 2015-10-06 at 17:21 +0200, Juergen Gross wrote: >> On 10/06/2015 05:11 PM, Ian Campbell wrote: >>> On Tue, 2015-10-06 at 16:51 +0200, Juergen Gross wrote: On 10/06/2015 03:40 PM, Ian Campbell wrote: > On Tue, 2015-10-06 at 12:39 +0100,

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Juergen Gross
On 10/06/2015 05:11 PM, Ian Campbell wrote: On Tue, 2015-10-06 at 16:51 +0200, Juergen Gross wrote: On 10/06/2015 03:40 PM, Ian Campbell wrote: On Tue, 2015-10-06 at 12:39 +0100, Wei Liu wrote: And for the record, if my google-fu doesn't fail me, it's possible to load shared library into pyth

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Ian Campbell
On Tue, 2015-10-06 at 17:21 +0200, Juergen Gross wrote: > On 10/06/2015 05:11 PM, Ian Campbell wrote: > > On Tue, 2015-10-06 at 16:51 +0200, Juergen Gross wrote: > > > On 10/06/2015 03:40 PM, Ian Campbell wrote: > > > > On Tue, 2015-10-06 at 12:39 +0100, Wei Liu wrote: > > > > > > > > > And for th

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Zhigang Wang
On 10/06/2015 10:51 AM, Juergen Gross wrote: > On 10/06/2015 03:40 PM, Ian Campbell wrote: >> On Tue, 2015-10-06 at 12:39 +0100, Wei Liu wrote: >> >>> And for the record, if my google-fu doesn't fail me, it's possible to >>> load shared library into python interpreter using "dl" module in 2.7 and >

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Ian Campbell
On Tue, 2015-10-06 at 16:51 +0200, Juergen Gross wrote: > On 10/06/2015 03:40 PM, Ian Campbell wrote: > > On Tue, 2015-10-06 at 12:39 +0100, Wei Liu wrote: > > > > > And for the record, if my google-fu doesn't fail me, it's possible to > > > load shared library into python interpreter using "dl" m

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Juergen Gross
On 10/06/2015 03:40 PM, Ian Campbell wrote: On Tue, 2015-10-06 at 12:39 +0100, Wei Liu wrote: And for the record, if my google-fu doesn't fail me, it's possible to load shared library into python interpreter using "dl" module in 2.7 and "ctypes" module in 3.x. Possible, but not especially con

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Ian Campbell
On Tue, 2015-10-06 at 12:39 +0100, Wei Liu wrote: > And for the record, if my google-fu doesn't fail me, it's possible to > load shared library into python interpreter using "dl" module in 2.7 and > "ctypes" module in 3.x. Possible, but not especially convenient since you need to convert the C pr

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Wei Liu
On Tue, Oct 06, 2015 at 01:33:54PM +0200, Juergen Gross wrote: > On 10/06/2015 01:18 PM, Wei Liu wrote: > >On Tue, Oct 06, 2015 at 12:46:08PM +0200, Juergen Gross wrote: > >>Remove lots of functions in tools/python/xen/lowlevel/xc/xc.c as they > >>are not used anywhere in the tree. In fact only one

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Juergen Gross
On 10/06/2015 01:18 PM, Wei Liu wrote: On Tue, Oct 06, 2015 at 12:46:08PM +0200, Juergen Gross wrote: Remove lots of functions in tools/python/xen/lowlevel/xc/xc.c as they are not used anywhere in the tree. In fact only one function is still being used from pygrub, namely "xeninfo". All other us

Re: [Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Wei Liu
On Tue, Oct 06, 2015 at 12:46:08PM +0200, Juergen Gross wrote: > Remove lots of functions in tools/python/xen/lowlevel/xc/xc.c as they > are not used anywhere in the tree. In fact only one function is still > being used from pygrub, namely "xeninfo". All other users seem to have > gone with nuking

[Xen-devel] [PATCH] tools: remove unused wrappers for python

2015-10-06 Thread Juergen Gross
Remove lots of functions in tools/python/xen/lowlevel/xc/xc.c as they are not used anywhere in the tree. In fact only one function is still being used from pygrub, namely "xeninfo". All other users seem to have gone with nuking xm/xend. Signed-off-by: Juergen Gross --- tools/python/xen/lowlevel/