Re: [Xen-devel] [PATCH] tools: libxl: free devpath on failure in libxl__blktap_devpath

2016-02-16 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] tools: libxl: free devpath on failure in libxl__blktap_devpath"): > On Tue, Feb 16, 2016 at 11:09:43AM +, Ian Campbell wrote: > > The underlying code paths in tap_ctl_create attempt to handle both > > *devpath == NULL (by allocating) and *devpath != NULL (caller pr

Re: [Xen-devel] [PATCH] tools: libxl: free devpath on failure in libxl__blktap_devpath

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 11:09:43AM +, Ian Campbell wrote: > The underlying code paths in tap_ctl_create attempt to handle both > *devpath == NULL (by allocating) and *devpath != NULL (caller provided > name) and if they allocate tend to write the return immediately before > doing other potentia

[Xen-devel] [PATCH] tools: libxl: free devpath on failure in libxl__blktap_devpath

2016-02-16 Thread Ian Campbell
The underlying code paths in tap_ctl_create attempt to handle both *devpath == NULL (by allocating) and *devpath != NULL (caller provided name) and if they allocate tend to write the return immediately before doing other potentially error generating tasks. All of which makes handling this at a lowe