Re: [Xen-devel] [PATCH] tools: libxl: Take the userdata lock around maxmem changes

2015-06-26 Thread Ian Campbell
On Wed, 2015-06-24 at 10:30 +0100, Wei Liu wrote: > Acked-by: Wei Liu Applied, thanks. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] tools: libxl: Take the userdata lock around maxmem changes

2015-06-24 Thread Wei Liu
On Tue, Jun 23, 2015 at 03:58:32PM +0100, Ian Campbell wrote: > There is an issue in libxl_set_memory_target whereby the target and > the max mem can get out of sync, this is because the call the > xc_domain_setmaxmem is not tied in any way to the xenstore transaction > which controls updates to th

Re: [Xen-devel] [PATCH] tools: libxl: Take the userdata lock around maxmem changes

2015-06-24 Thread Ian Campbell
On Tue, 2015-06-23 at 19:50 +0100, Wei Liu wrote: > On Tue, Jun 23, 2015 at 05:38:17PM +0100, Ian Campbell wrote: > > On Tue, 2015-06-23 at 17:32 +0100, Wei Liu wrote: > > > On Tue, Jun 23, 2015 at 03:58:32PM +0100, Ian Campbell wrote: > > > > There is an issue in libxl_set_memory_target whereby th

Re: [Xen-devel] [PATCH] tools: libxl: Take the userdata lock around maxmem changes

2015-06-23 Thread Wei Liu
On Tue, Jun 23, 2015 at 05:38:17PM +0100, Ian Campbell wrote: > On Tue, 2015-06-23 at 17:32 +0100, Wei Liu wrote: > > On Tue, Jun 23, 2015 at 03:58:32PM +0100, Ian Campbell wrote: > > > There is an issue in libxl_set_memory_target whereby the target and > > > the max mem can get out of sync, this i

Re: [Xen-devel] [PATCH] tools: libxl: Take the userdata lock around maxmem changes

2015-06-23 Thread Ian Campbell
On Tue, 2015-06-23 at 17:32 +0100, Wei Liu wrote: > On Tue, Jun 23, 2015 at 03:58:32PM +0100, Ian Campbell wrote: > > There is an issue in libxl_set_memory_target whereby the target and > > the max mem can get out of sync, this is because the call the > > xc_domain_setmaxmem is not tied in any way

Re: [Xen-devel] [PATCH] tools: libxl: Take the userdata lock around maxmem changes

2015-06-23 Thread Wei Liu
On Tue, Jun 23, 2015 at 03:58:32PM +0100, Ian Campbell wrote: > There is an issue in libxl_set_memory_target whereby the target and > the max mem can get out of sync, this is because the call the > xc_domain_setmaxmem is not tied in any way to the xenstore transaction > which controls updates to th

[Xen-devel] [PATCH] tools: libxl: Take the userdata lock around maxmem changes

2015-06-23 Thread Ian Campbell
There is an issue in libxl_set_memory_target whereby the target and the max mem can get out of sync, this is because the call the xc_domain_setmaxmem is not tied in any way to the xenstore transaction which controls updates to the xenstore side of things. Consider a domain with 1M of RAM (==target