Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-22 Thread Ian Campbell
On Fri, 2015-10-16 at 12:46 +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH] tools: libxl: CODING_STYLE: GC* cannot be > used with NOGC"): > > On Fri, Oct 16, 2015 at 12:14:05PM +0100, Ian Campbell wrote: > > > On Fri, 2015-10-16 at 11:39 +0100, Wei Liu wrote: > > > > There is no libxl__all

Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC"): > On Fri, Oct 16, 2015 at 12:14:05PM +0100, Ian Campbell wrote: > > On Fri, 2015-10-16 at 11:39 +0100, Wei Liu wrote: > > > There is no libxl__alloc. DYM libxl__malloc? > > > > I meant libxl__calloc. Right,

Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 12:14:05PM +0100, Ian Campbell wrote: > On Fri, 2015-10-16 at 11:39 +0100, Wei Liu wrote: > > On Fri, Oct 16, 2015 at 11:33:12AM +0100, Ian Campbell wrote: > > > GC* assume an existing gc in scope, which means they can't be passed > > > NOGC. Instead recommend the use of the

Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Ian Campbell
On Fri, 2015-10-16 at 11:39 +0100, Wei Liu wrote: > On Fri, Oct 16, 2015 at 11:33:12AM +0100, Ian Campbell wrote: > > GC* assume an existing gc in scope, which means they can't be passed > > NOGC. Instead recommend the use of the underlying functions with NOGC, > > noting that this is excepitonal.

Re: [Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 11:33:12AM +0100, Ian Campbell wrote: > GC* assume an existing gc in scope, which means they can't be passed > NOGC. Instead recommend the use of the underlying functions with NOGC, > noting that this is excepitonal. > > Signed-off-by: Ian Campbell > --- > tools/libxl/COD

[Xen-devel] [PATCH] tools: libxl: CODING_STYLE: GC* cannot be used with NOGC

2015-10-16 Thread Ian Campbell
GC* assume an existing gc in scope, which means they can't be passed NOGC. Instead recommend the use of the underlying functions with NOGC, noting that this is excepitonal. Signed-off-by: Ian Campbell --- tools/libxl/CODING_STYLE | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi