Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0

2017-10-18 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0"): > CC'ing Julien for a release ack, as this is a blocker (due to regressing > the xendevicemodel ABI from Xen 4.9) Julien told me that straightforward bugfixes, whic

Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0

2017-10-18 Thread Ross Lagerwall
On 10/17/2017 06:05 PM, Ian Jackson wrote: In 1462f9ea8f4219d520a530787b80c986e050aa98 "tools: libxendevicemodel: Provide xendevicemodel_shutdown" we added a new version 1.1 to the symbol map and simply abolished the old one. That is quite wrong. Instead, we should have left the 1.0 map alone a

Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0

2017-10-17 Thread Andrew Cooper
On 17/10/17 18:06, Wei Liu wrote: > On Tue, Oct 17, 2017 at 06:05:35PM +0100, Ian Jackson wrote: >> In 1462f9ea8f4219d520a530787b80c986e050aa98 >> "tools: libxendevicemodel: Provide xendevicemodel_shutdown" >> we added a new version 1.1 to the symbol map and simply abolished >> the old one. That i

Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0

2017-10-17 Thread Wei Liu
On Tue, Oct 17, 2017 at 06:05:35PM +0100, Ian Jackson wrote: > In 1462f9ea8f4219d520a530787b80c986e050aa98 > "tools: libxendevicemodel: Provide xendevicemodel_shutdown" > we added a new version 1.1 to the symbol map and simply abolished > the old one. That is quite wrong. > > Instead, we should h

[Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0

2017-10-17 Thread Ian Jackson
In 1462f9ea8f4219d520a530787b80c986e050aa98 "tools: libxendevicemodel: Provide xendevicemodel_shutdown" we added a new version 1.1 to the symbol map and simply abolished the old one. That is quite wrong. Instead, we should have left the 1.0 map alone and added a new version which simply adds the