Re: [Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation

2017-04-05 Thread Jan Beulich
>>> On 05.04.17 at 15:27, wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools/xenstore: Add > -Wno-bool-operation"): >> I'm fairly sure this will break the Clang build. > > This seems unlikely. I assume that clang has the same behaviour as &g

Re: [Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation

2017-04-05 Thread Andrew Cooper
On 05/04/17 14:43, Andrew Cooper wrote: > On 05/04/17 14:27, Ian Jackson wrote: >> Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools/xenstore: Add >> -Wno-bool-operation"): >>> I'm fairly sure this will break the Clang build. >> This seems unlikel

Re: [Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation

2017-04-05 Thread Andrew Cooper
On 05/04/17 14:27, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools/xenstore: Add > -Wno-bool-operation"): >> I'm fairly sure this will break the Clang build. > This seems unlikely. Have you tried? > I assume that clang has the same b

Re: [Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation

2017-04-05 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation"): > I'm fairly sure this will break the Clang build. This seems unlikely. I assume that clang has the same behaviour as gcc, for -Wno-unknown-warning. > Furthermore, the proper fix

Re: [Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation

2017-04-05 Thread Andrew Cooper
On 05/04/17 14:13, Ian Jackson wrote: > This suppresses a warning from GCC7 > xenstored_domain.c:949:32: error: increment of a boolean expression > > We have not yet 100% concluded that this should not be fixed by > changing the `_Bool b; b++;' to `b = 1'. But this fixes the warning > and thus t

[Xen-devel] [PATCH] tools/xenstore: Add -Wno-bool-operation

2017-04-05 Thread Ian Jackson
This suppresses a warning from GCC7 xenstored_domain.c:949:32: error: increment of a boolean expression We have not yet 100% concluded that this should not be fixed by changing the `_Bool b; b++;' to `b = 1'. But this fixes the warning and thus the build for now, and we want to apply the XSA-20