Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 16:02 +, Ross Lagerwall wrote: > On 03/20/2015 11:15 AM, Ian Campbell wrote: > > On Fri, 2015-03-20 at 11:03 +, Ian Campbell wrote: > >> Do the new callers actually need the number of bytes read/written or was > >> this just something which seemed like a good idea sinc

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ross Lagerwall
On 03/20/2015 11:15 AM, Ian Campbell wrote: On Fri, 2015-03-20 at 11:03 +, Ian Campbell wrote: Do the new callers actually need the number of bytes read/written or was this just something which seemed like a good idea since it was in hand? If it isn't needed In fact, irrespective of the n

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 11:03 +, Ian Campbell wrote: > Do the new callers actually need the number of bytes read/written or was > this just something which seemed like a good idea since it was in hand? > > If it isn't needed In fact, irrespective of the needs of the future callers lets go back

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 16:17 +0800, Wen Congyang wrote: > After commit 6d896e13, we should pass -errno on read failure. Hrm, this means that 6d896e13 was a more subtle interface change than I was expecting (I'd forgotten that errno wasn't negative in userspace). This means that someone needs to au

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Wen Congyang
On 03/20/2015 04:25 PM, Ross Lagerwall wrote: > On 03/20/2015 08:17 AM, Wen Congyang wrote: >> After commit 6d896e13, we should pass -errno on read failure. >> >> Signed-off-by: Wen Congyang >> --- >> tools/libxl/libxl_aoutils.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> dif

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ross Lagerwall
On 03/20/2015 08:17 AM, Wen Congyang wrote: After commit 6d896e13, we should pass -errno on read failure. Signed-off-by: Wen Congyang --- tools/libxl/libxl_aoutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_aoutils.c b/tools/libxl/libxl_aoutils.c

[Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Wen Congyang
After commit 6d896e13, we should pass -errno on read failure. Signed-off-by: Wen Congyang --- tools/libxl/libxl_aoutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_aoutils.c b/tools/libxl/libxl_aoutils.c index 0d4c8af..b93f0e4 100644 --- a/tools/libxl/