Re: [Xen-devel] [PATCH] stubdom: fix make clean and distclean on a freshly cloned tree

2015-03-02 Thread Wei Liu
On Mon, Mar 02, 2015 at 02:15:43PM +, Ian Campbell wrote: > On Mon, 2015-03-02 at 11:15 +, Wei Liu wrote: > > > -include $(XEN_ROOT)/Config.mk > > > + > > > +ifeq (,$(findstring clean,$(MAKECMDGOALS))) > > > + ifeq ($(wildcard $(MINI_OS)/Config.mk),) > > > > +$(error Please run `make

Re: [Xen-devel] [PATCH] stubdom: fix make clean and distclean on a freshly cloned tree

2015-03-02 Thread Ian Campbell
On Mon, 2015-03-02 at 11:15 +, Wei Liu wrote: > > -include $(XEN_ROOT)/Config.mk > > + > > +ifeq (,$(findstring clean,$(MAKECMDGOALS))) > > + ifeq ($(wildcard $(MINI_OS)/Config.mk),) > > +$(error Please run `make mini-os-dir' in top-level directory) > > + endif > > + include $(XEN_ROOT)

Re: [Xen-devel] [PATCH] stubdom: fix make clean and distclean on a freshly cloned tree

2015-03-02 Thread Ian Campbell
On Mon, 2015-03-02 at 14:25 +, Wei Liu wrote: > > > > +endif > > > > + > > > > -include $(XEN_ROOT)/config/Stubdom.mk > > > > > > > > GNU_TARGET_ARCH:=$(XEN_TARGET_ARCH) > > > > diff --git a/stubdom/c/Makefile b/stubdom/c/Makefile > > > > index c646c26..b252dca 100644 > > > > --- a/stubdom/

Re: [Xen-devel] [PATCH] stubdom: fix make clean and distclean on a freshly cloned tree

2015-03-02 Thread Wei Liu
CC Samuel and Stefano. On Mon, Mar 02, 2015 at 11:09:10AM +, Wei Liu wrote: > Clean and distclean targets need not depend on existence of the mini-os > tree. Don't check for mini-os and don't try to blindly include > mini-os's Config.mk when doing clean and distclean. > > Reported-by: Sander

[Xen-devel] [PATCH] stubdom: fix make clean and distclean on a freshly cloned tree

2015-03-02 Thread Wei Liu
Clean and distclean targets need not depend on existence of the mini-os tree. Don't check for mini-os and don't try to blindly include mini-os's Config.mk when doing clean and distclean. Reported-by: Sander Eikelenboom Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson --- stubdom/Makefi