Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 12:14:33PM +, Ian Campbell wrote: > On Tue, 2016-02-16 at 10:29 +, Wei Liu wrote: > > On Tue, Feb 16, 2016 at 09:10:20AM +, Ian Campbell wrote: > > > On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > > > > Previously in the three problematic libraries all publi

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Ian Campbell
On Tue, 2016-02-16 at 10:29 +, Wei Liu wrote: > On Tue, Feb 16, 2016 at 09:10:20AM +, Ian Campbell wrote: > > On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > > > Previously in the three problematic libraries all public headers > were > > > linked to source code directory. We should have

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Wei Liu
On Tue, Feb 16, 2016 at 09:10:20AM +, Ian Campbell wrote: > On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > > Previously in the three problematic libraries all public headers were > > linked to source code directory. We should have created a include > > directory and link headers there. >

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-16 Thread Ian Campbell
On Mon, 2016-02-15 at 19:40 +, Wei Liu wrote: > Previously in the three problematic libraries all public headers were > linked to source code directory. We should have created a include > directory and link headers there. What breakage arose from not having done so? > > Signed-off-by: Wei Li

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-15 Thread Samuel Thibault
Wei Liu, on Mon 15 Feb 2016 19:40:28 +, wrote: > Previously in the three problematic libraries all public headers were > linked to source code directory. We should have created a include > directory and link headers there. > > Signed-off-by: Wei Liu Indeed, 31d2d1e0 (Move xenstore and libxc

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-15 Thread Wei Liu
On Mon, Feb 15, 2016 at 07:40:28PM +, Wei Liu wrote: > Previously in the three problematic libraries all public headers were > linked to source code directory. We should have created a include > directory and link headers there. We should have created an include directory for each library and

[Xen-devel] [PATCH] stubdom: fix link farm runes

2016-02-15 Thread Wei Liu
Previously in the three problematic libraries all public headers were linked to source code directory. We should have created a include directory and link headers there. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu Cc: Samuel Thibault --- st