Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-11-03 Thread Dario Faggioli
On Tue, 2015-11-03 at 05:38 -0700, Jan Beulich wrote: > > > > On 03.11.15 at 11:16, wrote: > > So you agree that this change makes the source code make more sense > > ("looks like an improvement at the source level"), but you think > > that > > this will make the compiled code less efficient; and

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-11-03 Thread Jan Beulich
>>> On 03.11.15 at 11:16, wrote: > On Fri, Oct 30, 2015 at 5:00 PM, Jan Beulich wrote: > On 30.10.15 at 17:33, wrote: >>> On Fri, 2015-10-30 at 10:25 -0600, Jan Beulich wrote: > > > On 30.10.15 at 16:09, wrote: > --- a/xen/common/sched_credit.c > +++ b/xen/common/sched_credit

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-11-03 Thread George Dunlap
On Fri, Oct 30, 2015 at 5:00 PM, Jan Beulich wrote: On 30.10.15 at 17:33, wrote: >> On Fri, 2015-10-30 at 10:25 -0600, Jan Beulich wrote: >>> > > > On 30.10.15 at 16:09, wrote: >>> > --- a/xen/common/sched_credit.c >>> > +++ b/xen/common/sched_credit.c >>> > @@ -252,13 +252,12 @@ __runq_ele

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-11-02 Thread Wei Liu
On Fri, Oct 30, 2015 at 06:01:36PM +0100, Dario Faggioli wrote: > On Fri, 2015-10-30 at 22:20 +0530, Harmandeep Kaur wrote: > > On Fri, Oct 30, 2015 at 10:16 PM, Dario Faggioli < > > dario.faggi...@citrix.com> wrote: > > > The list of people you Cc-ed, is not really accurate. In fact, Ian > > > Cam

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-11-02 Thread Dario Faggioli
[Trimming the Cc list, and adding George, which I did not realize he was not there!] On Fri, 2015-10-30 at 11:00 -0600, Jan Beulich wrote: > > > > On 30.10.15 at 17:33, wrote: > > Are you saying that we shouldn't make the change at all? Or that we > > should make the change and also turn the B

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-10-30 Thread Harmandeep Kaur
On Fri, Oct 30, 2015 at 10:16 PM, Dario Faggioli wrote: > On Fri, 2015-10-30 at 20:39 +0530, Harmandeep Kaur wrote: > > __runq_insert() takes two arguments, cpu and svc. However, > > the cpu argument is redundant because we can get all the > > information we need about cpu from svc. > > > > Signe

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-10-30 Thread Dario Faggioli
On Fri, 2015-10-30 at 22:20 +0530, Harmandeep Kaur wrote: > On Fri, Oct 30, 2015 at 10:16 PM, Dario Faggioli < > dario.faggi...@citrix.com> wrote: > > The list of people you Cc-ed, is not really accurate. In fact, Ian > > Campbell and Ian Jackson are toolstack maintainers, and even Jan, > > Keir >

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-10-30 Thread Jan Beulich
>>> On 30.10.15 at 17:33, wrote: > On Fri, 2015-10-30 at 10:25 -0600, Jan Beulich wrote: >> > > > On 30.10.15 at 16:09, wrote: >> > --- a/xen/common/sched_credit.c >> > +++ b/xen/common/sched_credit.c >> > @@ -252,13 +252,12 @@ __runq_elem(struct list_head *elem) >> > } >> > >> > static inlin

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-10-30 Thread Dario Faggioli
On Fri, 2015-10-30 at 20:39 +0530, Harmandeep Kaur wrote: > __runq_insert() takes two arguments, cpu and svc. However, > the cpu argument is redundant because we can get all the > information we need about cpu from svc. > > Signed-off-by: Harmandeep Kaur > Thanks Harman, this looks good. Just one

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-10-30 Thread Dario Faggioli
On Fri, 2015-10-30 at 10:25 -0600, Jan Beulich wrote: > > > > On 30.10.15 at 16:09, wrote: > > --- a/xen/common/sched_credit.c > > +++ b/xen/common/sched_credit.c > > @@ -252,13 +252,12 @@ __runq_elem(struct list_head *elem) > > } > > > > static inline void > > -__runq_insert(unsigned int cpu

Re: [Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-10-30 Thread Jan Beulich
>>> On 30.10.15 at 16:09, wrote: > __runq_insert() takes two arguments, cpu and svc. However, > the cpu argument is redundant because we can get all the > information we need about cpu from svc. While true and looking like an improvement at the source level, ... > --- a/xen/common/sched_credit.c

[Xen-devel] [PATCH] sched_credit: Remove cpu argument to __runq_insert()

2015-10-30 Thread Harmandeep Kaur
__runq_insert() takes two arguments, cpu and svc. However, the cpu argument is redundant because we can get all the information we need about cpu from svc. Signed-off-by: Harmandeep Kaur --- xen/common/sched_credit.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a