Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-26 Thread Olaf Hering
Am Mon, 26 Jun 2017 05:55:17 -0600 schrieb "Jan Beulich" : > Unlike PIC, PIE was introduced later, yet might still be defaulted to. Hence > it may be necessary to also deal with that, instead of just addressing one > half. There is now v2 which uses cc-option-add > In the unstable staging tree

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-26 Thread Jan Beulich
>>> Olaf Hering 06/26/17 8:47 AM >>> >Am Mon, 26 Jun 2017 00:30:50 -0600 >schrieb "Jan Beulich" : > >> In the description you also talk about PIE, but you deal with PIC only here. >> Is that intentional? If so, please say why in the description. > >Thats what the URL says. Unclear what the connec

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-25 Thread Olaf Hering
Am Mon, 26 Jun 2017 00:30:50 -0600 schrieb "Jan Beulich" : > In the description you also talk about PIE, but you deal with PIC only here. > Is that intentional? If so, please say why in the description. Thats what the URL says. Unclear what the connection between -fpic and -fPIE (?) is. > Also

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-25 Thread Jan Beulich
>>> Olaf Hering 06/23/17 7:27 PM >>> >--- a/tools/firmware/rombios/32bit/Makefile >+++ b/tools/firmware/rombios/32bit/Makefile >@@ -3,7 +3,7 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk > >TARGET = 32bitbios_flat.h > >-CFLAGS += $(CFLAGS_xeninclude) -I.. -I../../../libacpi >+CFLAGS += $(CFLAG

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-23 Thread Olaf Hering
On Fri, Jun 23, Wei Liu wrote: > We support >=4.1. Please check those as well. Yes, 4.1.2 works as well. Olaf signature.asc Description: PGP signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-23 Thread Olaf Hering
On Fri, Jun 23, Wei Liu wrote: > We support >=4.1. Please check those as well. According to the PDF manuals at https://gcc.gnu.org/onlinedocs/ a "-fno-foo" is mentioned, so I think -fno-pic is recognized. I will see if I find a copy of SLE10 to verify with 4.1.2. Olaf signature.asc Descriptio

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-23 Thread Wei Liu
On Fri, Jun 23, 2017 at 07:40:36PM +0200, Olaf Hering wrote: > On Fri, Jun 23, Wei Liu wrote: > > > Do you need to check if the compiler supports -fno-pic? > > In my testing gcc-4.3 and 4.5 know about this option. > We support >=4.1. Please check those as well.

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-23 Thread Olaf Hering
On Fri, Jun 23, Wei Liu wrote: > Do you need to check if the compiler supports -fno-pic? In my testing gcc-4.3 and 4.5 know about this option. Olaf signature.asc Description: PGP signature ___ Xen-devel mailing list Xen-devel@lists.xen.org https://li

Re: [Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-23 Thread Wei Liu
On Fri, Jun 23, 2017 at 07:26:01PM +0200, Olaf Hering wrote: > If the default compiler silently defaults to to -fPIC/-fPIE building > rombios fails: > > ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o > 32bitbios_all.o > There are undefined symbols in the BIOS: >

[Xen-devel] [PATCH] rombios: prevent building with PIC

2017-06-23 Thread Olaf Hering
If the default compiler silently defaults to to -fPIC/-fPIE building rombios fails: ld -melf_i386 -s -r 32bitbios.o tcgbios/tcgbiosext.o util.o pmm.o -o 32bitbios_all.o There are undefined symbols in the BIOS: U _GLOBAL_OFFSET_TABLE_ make[10]: *** [Makefile:26: 32bitbios_all.o] Error