Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-09-06 Thread Andrew Cooper
On 06/09/16 09:03, Jan Beulich wrote: On 12.08.16 at 13:49, wrote: >> On 12/08/16 11:58, Jan Beulich wrote: >> On 11.08.16 at 20:10, wrote: On 09/08/16 11:40, Jan Beulich wrote: > --- a/xen/arch/x86/cpu/mtrr/main.c > +++ b/xen/arch/x86/cpu/mtrr/main.c > @@ -332,7 +332,7

Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-09-06 Thread Jan Beulich
>>> On 12.08.16 at 13:49, wrote: > On 12/08/16 11:58, Jan Beulich wrote: > On 11.08.16 at 20:10, wrote: >>> On 09/08/16 11:40, Jan Beulich wrote: --- a/xen/arch/x86/cpu/mtrr/main.c +++ b/xen/arch/x86/cpu/mtrr/main.c @@ -332,7 +332,7 @@ int mtrr_add_page(unsigned long base, un >

Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-09-05 Thread George Dunlap
On Tue, Aug 9, 2016 at 11:40 AM, Jan Beulich wrote: > This doesn't cover all of them, just the ones that I think would most > obviously better be -EINVAL or -EOPNOTSUPP. > > Signed-off-by: Jan Beulich FWIW: Reviewed-by: George Dunlap > > --- a/xen/arch/x86/cpu/mcheck/vmce.c > +++ b/xen/arch/x

Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-08-12 Thread Andrew Cooper
On 12/08/16 11:58, Jan Beulich wrote: On 11.08.16 at 20:10, wrote: >> On 09/08/16 11:40, Jan Beulich wrote: >>> --- a/xen/arch/x86/cpu/mtrr/main.c >>> +++ b/xen/arch/x86/cpu/mtrr/main.c >>> @@ -332,7 +332,7 @@ int mtrr_add_page(unsigned long base, un >>> if ((type == MTRR_TYPE_WRCOMB) &&

Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-08-12 Thread Jan Beulich
>>> On 12.08.16 at 12:34, wrote: > On 11/08/16 19:10, Andrew Cooper wrote: >> On 09/08/16 11:40, Jan Beulich wrote: >>> --- a/xen/arch/x86/cpu/mtrr/main.c >>> +++ b/xen/arch/x86/cpu/mtrr/main.c >>> @@ -332,7 +332,7 @@ int mtrr_add_page(unsigned long base, un >>> if ((type == MTRR_TYPE_WRCOMB)

Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-08-12 Thread Jan Beulich
>>> On 11.08.16 at 20:10, wrote: > On 09/08/16 11:40, Jan Beulich wrote: >> --- a/xen/arch/x86/cpu/mtrr/main.c >> +++ b/xen/arch/x86/cpu/mtrr/main.c >> @@ -332,7 +332,7 @@ int mtrr_add_page(unsigned long base, un >> if ((type == MTRR_TYPE_WRCOMB) && !have_wrcomb()) { >> printk(KE

Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-08-12 Thread George Dunlap
On 11/08/16 19:10, Andrew Cooper wrote: > On 09/08/16 11:40, Jan Beulich wrote: >> --- a/xen/arch/x86/cpu/mtrr/main.c >> +++ b/xen/arch/x86/cpu/mtrr/main.c >> @@ -332,7 +332,7 @@ int mtrr_add_page(unsigned long base, un >> if ((type == MTRR_TYPE_WRCOMB) && !have_wrcomb()) { >> pri

Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-08-11 Thread Andrew Cooper
On 09/08/16 11:40, Jan Beulich wrote: > --- a/xen/arch/x86/cpu/mtrr/main.c > +++ b/xen/arch/x86/cpu/mtrr/main.c > @@ -332,7 +332,7 @@ int mtrr_add_page(unsigned long base, un > if ((type == MTRR_TYPE_WRCOMB) && !have_wrcomb()) { > printk(KERN_WARNING > "mtrr

[Xen-devel] [PATCH] replace bogus -ENOSYS uses

2016-08-09 Thread Jan Beulich
This doesn't cover all of them, just the ones that I think would most obviously better be -EINVAL or -EOPNOTSUPP. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mcheck/vmce.c +++ b/xen/arch/x86/cpu/mcheck/vmce.c @@ -440,7 +440,7 @@ int unmmap_broken_page(struct domain *d, return -EIN