Re: [Xen-devel] [PATCH] ocaml/xenctrl: Make failwith_xc() thread safe

2015-02-02 Thread Ian Campbell
On Fri, 2015-01-30 at 14:24 +, Dave Scott wrote: > > > On 30 Jan 2015, at 14:20, Wei Liu wrote: > > > > On Fri, Jan 30, 2015 at 02:19:53PM +, Dave Scott wrote: > >> > >> Looks ok to me. > >> > >> Signed-off-by: David Scott > >> > > > > I think this should be an Acked-by. > > Sorry,

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Make failwith_xc() thread safe

2015-01-30 Thread Dave Scott
> On 30 Jan 2015, at 14:20, Wei Liu wrote: > > On Fri, Jan 30, 2015 at 02:19:53PM +, Dave Scott wrote: >> >> Looks ok to me. >> >> Signed-off-by: David Scott >> > > I think this should be an Acked-by. Sorry, you’re completely right. Muscle memory strikes again! :) Acked-by: David Scot

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Make failwith_xc() thread safe

2015-01-30 Thread Wei Liu
On Fri, Jan 30, 2015 at 02:19:53PM +, Dave Scott wrote: > > Looks ok to me. > > Signed-off-by: David Scott > I think this should be an Acked-by. Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] ocaml/xenctrl: Make failwith_xc() thread safe

2015-01-30 Thread Dave Scott
Looks ok to me. Signed-off-by: David Scott > On 28 Jan 2015, at 17:55, Andrew Cooper wrote: > > The static error_str[] buffer is not thread-safe, and 1024 bytes is > unreasonably large. Reduce to 256 bytes (which is still much larger than any > current use), and move it to being a stack vari

[Xen-devel] [PATCH] ocaml/xenctrl: Make failwith_xc() thread safe

2015-01-28 Thread Andrew Cooper
The static error_str[] buffer is not thread-safe, and 1024 bytes is unreasonably large. Reduce to 256 bytes (which is still much larger than any current use), and move it to being a stack variable. Also, propagate the Noreturn attribute from caml_raise_with_string(). Signed-off-by: Andrew Cooper