On Fri, 2015-01-30 at 14:24 +, Dave Scott wrote:
>
> > On 30 Jan 2015, at 14:20, Wei Liu wrote:
> >
> > On Fri, Jan 30, 2015 at 02:19:53PM +, Dave Scott wrote:
> >>
> >> Looks ok to me.
> >>
> >> Signed-off-by: David Scott
> >>
> >
> > I think this should be an Acked-by.
>
> Sorry,
> On 30 Jan 2015, at 14:20, Wei Liu wrote:
>
> On Fri, Jan 30, 2015 at 02:19:53PM +, Dave Scott wrote:
>>
>> Looks ok to me.
>>
>> Signed-off-by: David Scott
>>
>
> I think this should be an Acked-by.
Sorry, you’re completely right. Muscle memory strikes again! :)
Acked-by: David Scot
On Fri, Jan 30, 2015 at 02:19:53PM +, Dave Scott wrote:
>
> Looks ok to me.
>
> Signed-off-by: David Scott
>
I think this should be an Acked-by.
Wei.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Looks ok to me.
Signed-off-by: David Scott
> On 28 Jan 2015, at 17:55, Andrew Cooper wrote:
>
> The static error_str[] buffer is not thread-safe, and 1024 bytes is
> unreasonably large. Reduce to 256 bytes (which is still much larger than any
> current use), and move it to being a stack vari
The static error_str[] buffer is not thread-safe, and 1024 bytes is
unreasonably large. Reduce to 256 bytes (which is still much larger than any
current use), and move it to being a stack variable.
Also, propagate the Noreturn attribute from caml_raise_with_string().
Signed-off-by: Andrew Cooper