Re: [Xen-devel] [PATCH] memory: fix compat handling of XENMEM_access_op

2016-09-02 Thread Andrew Cooper
On 30/08/16 10:15, Jan Beulich wrote: > Within compat_memory_op() this needs to be placed in the first switch() > statement, or it ends up being dead code (as that first switch() has a > default case chaining to compat_arch_memory_op()). > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper

Re: [Xen-devel] [PATCH] memory: fix compat handling of XENMEM_access_op

2016-08-30 Thread Razvan Cojocaru
On 08/30/2016 01:05 PM, Jan Beulich wrote: On 30.08.16 at 11:46, wrote: >> On 08/30/2016 12:15 PM, Jan Beulich wrote: >>> Within compat_memory_op() this needs to be placed in the first switch() >>> statement, or it ends up being dead code (as that first switch() has a >>> default case chainin

Re: [Xen-devel] [PATCH] memory: fix compat handling of XENMEM_access_op

2016-08-30 Thread Jan Beulich
>>> On 30.08.16 at 11:46, wrote: > On 08/30/2016 12:15 PM, Jan Beulich wrote: >> Within compat_memory_op() this needs to be placed in the first switch() >> statement, or it ends up being dead code (as that first switch() has a >> default case chaining to compat_arch_memory_op()). >> >> Signed-off

Re: [Xen-devel] [PATCH] memory: fix compat handling of XENMEM_access_op

2016-08-30 Thread Razvan Cojocaru
On 08/30/2016 12:15 PM, Jan Beulich wrote: > Within compat_memory_op() this needs to be placed in the first switch() > statement, or it ends up being dead code (as that first switch() has a > default case chaining to compat_arch_memory_op()). > > Signed-off-by: Jan Beulich > --- > Compile tested

[Xen-devel] [PATCH] memory: fix compat handling of XENMEM_access_op

2016-08-30 Thread Jan Beulich
Within compat_memory_op() this needs to be placed in the first switch() statement, or it ends up being dead code (as that first switch() has a default case chaining to compat_arch_memory_op()). Signed-off-by: Jan Beulich --- Compile tested only. --- a/xen/common/compat/memory.c +++ b/xen/common/