Re: [Xen-devel] [PATCH] lock down hypercall continuation encoding masks

2014-12-11 Thread Tim Deegan
At 11:31 + on 05 Dec (1417775465), Jan Beulich wrote: > Andrew validly points out that even if these masks aren't a formal part > of the hypercall interface, we aren't free to change them: A guest > suspended for migration in the middle of a continuation would fail to > work if resumed on a hyp

Re: [Xen-devel] [PATCH] lock down hypercall continuation encoding masks

2014-12-11 Thread Ian Campbell
On Fri, 2014-12-05 at 11:31 +, Jan Beulich wrote: > Andrew validly points out that even if these masks aren't a formal part > of the hypercall interface, we aren't free to change them: A guest > suspended for migration in the middle of a continuation would fail to > work if resumed on a hypervi

Re: [Xen-devel] [PATCH] lock down hypercall continuation encoding masks

2014-12-05 Thread Andrew Cooper
On 05/12/14 15:18, Jan Beulich wrote: On 05.12.14 at 16:01, wrote: >> On 05/12/14 14:47, Jan Beulich wrote: >> On 05.12.14 at 15:36, wrote: On 05/12/14 11:31, Jan Beulich wrote: > Andrew validly points out that even if these masks aren't a formal part > of the hypercall inte

Re: [Xen-devel] [PATCH] lock down hypercall continuation encoding masks

2014-12-05 Thread Jan Beulich
>>> On 05.12.14 at 16:01, wrote: > On 05/12/14 14:47, Jan Beulich wrote: > On 05.12.14 at 15:36, wrote: >>> On 05/12/14 11:31, Jan Beulich wrote: Andrew validly points out that even if these masks aren't a formal part of the hypercall interface, we aren't free to change them: A gues

Re: [Xen-devel] [PATCH] lock down hypercall continuation encoding masks

2014-12-05 Thread Andrew Cooper
On 05/12/14 14:47, Jan Beulich wrote: On 05.12.14 at 15:36, wrote: >> On 05/12/14 11:31, Jan Beulich wrote: >>> Andrew validly points out that even if these masks aren't a formal part >>> of the hypercall interface, we aren't free to change them: A guest >>> suspended for migration in the mid

Re: [Xen-devel] [PATCH] lock down hypercall continuation encoding masks

2014-12-05 Thread Jan Beulich
>>> On 05.12.14 at 15:36, wrote: > On 05/12/14 11:31, Jan Beulich wrote: >> Andrew validly points out that even if these masks aren't a formal part >> of the hypercall interface, we aren't free to change them: A guest >> suspended for migration in the middle of a continuation would fail to >> work

Re: [Xen-devel] [PATCH] lock down hypercall continuation encoding masks

2014-12-05 Thread Andrew Cooper
On 05/12/14 11:31, Jan Beulich wrote: > Andrew validly points out that even if these masks aren't a formal part > of the hypercall interface, we aren't free to change them: A guest > suspended for migration in the middle of a continuation would fail to > work if resumed on a hypervisor using a diff

[Xen-devel] [PATCH] lock down hypercall continuation encoding masks

2014-12-05 Thread Jan Beulich
Andrew validly points out that even if these masks aren't a formal part of the hypercall interface, we aren't free to change them: A guest suspended for migration in the middle of a continuation would fail to work if resumed on a hypervisor using a different value. Hence add respective comments to