Re: [Xen-devel] [PATCH] libxl: use llabs() instead abs() for int64_t argument

2016-08-03 Thread Wei Liu
On Wed, Aug 03, 2016 at 11:27:04AM +0200, Juergen Gross wrote: > On 03/08/16 11:13, Wei Liu wrote: > > On Tue, Aug 02, 2016 at 06:28:37PM +0100, Andrew Cooper wrote: > >> On 02/08/16 18:25, Juergen Gross wrote: > >>> Commit 57f8b13c724023c78fa15a80452d1de3e51a1418 ("libxl: memory size > >>> in kb r

Re: [Xen-devel] [PATCH] libxl: use llabs() instead abs() for int64_t argument

2016-08-03 Thread Juergen Gross
On 03/08/16 11:13, Wei Liu wrote: > On Tue, Aug 02, 2016 at 06:28:37PM +0100, Andrew Cooper wrote: >> On 02/08/16 18:25, Juergen Gross wrote: >>> Commit 57f8b13c724023c78fa15a80452d1de3e51a1418 ("libxl: memory size >>> in kb requires 64 bit variable") introduced a bug: abs() shouldn't >>> be called

Re: [Xen-devel] [PATCH] libxl: use llabs() instead abs() for int64_t argument

2016-08-03 Thread Wei Liu
On Tue, Aug 02, 2016 at 06:28:37PM +0100, Andrew Cooper wrote: > On 02/08/16 18:25, Juergen Gross wrote: > > Commit 57f8b13c724023c78fa15a80452d1de3e51a1418 ("libxl: memory size > > in kb requires 64 bit variable") introduced a bug: abs() shouldn't > > be called with an int64_t argument. llabs() is

Re: [Xen-devel] [PATCH] libxl: use llabs() instead abs() for int64_t argument

2016-08-02 Thread Andrew Cooper
On 02/08/16 18:25, Juergen Gross wrote: > Commit 57f8b13c724023c78fa15a80452d1de3e51a1418 ("libxl: memory size > in kb requires 64 bit variable") introduced a bug: abs() shouldn't > be called with an int64_t argument. llabs() is to be used here. Possibly worth identifying that this was caught by a

[Xen-devel] [PATCH] libxl: use llabs() instead abs() for int64_t argument

2016-08-02 Thread Juergen Gross
Commit 57f8b13c724023c78fa15a80452d1de3e51a1418 ("libxl: memory size in kb requires 64 bit variable") introduced a bug: abs() shouldn't be called with an int64_t argument. llabs() is to be used here. Signed-off-by: Juergen Gross --- tools/libxl/libxl.c | 2 +- 1 file changed, 1 insertion(+), 1 d