Re: [Xen-devel] [PATCH] libxl: update check-xl-disk-parse

2015-12-09 Thread Ian Campbell
On Wed, 2015-12-09 at 10:24 +, Wei Liu wrote: > On Wed, Dec 09, 2015 at 10:15:35AM +, Wei Liu wrote: > > On Wed, Dec 09, 2015 at 10:06:17AM +, Ian Campbell wrote: > > > On Tue, 2015-12-08 at 20:02 +, Wei Liu wrote: > > > > The block-attach command now returns 1 when fails. Update fi

Re: [Xen-devel] [PATCH] libxl: update check-xl-disk-parse

2015-12-09 Thread Wei Liu
On Wed, Dec 09, 2015 at 10:15:35AM +, Wei Liu wrote: > On Wed, Dec 09, 2015 at 10:06:17AM +, Ian Campbell wrote: > > On Tue, 2015-12-08 at 20:02 +, Wei Liu wrote: > > > The block-attach command now returns 1 when fails. Update first test > > > case to expect return value 1 instead of 25

Re: [Xen-devel] [PATCH] libxl: update check-xl-disk-parse

2015-12-09 Thread Wei Liu
On Wed, Dec 09, 2015 at 10:06:17AM +, Ian Campbell wrote: > On Tue, 2015-12-08 at 20:02 +, Wei Liu wrote: > > The block-attach command now returns 1 when fails. Update first test > > case to expect return value 1 instead of 255. > > > > The parser now doesn't generate output for default va

Re: [Xen-devel] [PATCH] libxl: update check-xl-disk-parse

2015-12-09 Thread Ian Campbell
On Tue, 2015-12-08 at 20:02 +, Wei Liu wrote: > The block-attach command now returns 1 when fails. Update first test > case to expect return value 1 instead of 255. > > The parser now doesn't generate output for default values. Remove them > from expected output. This it looks good. > The "d

[Xen-devel] [PATCH] libxl: update check-xl-disk-parse

2015-12-08 Thread Wei Liu
The block-attach command now returns 1 when fails. Update first test case to expect return value 1 instead of 255. The parser now doesn't generate output for default values. Remove them from expected output. The "discard=" variant is never not supported, so delete two test cases with that variant