Re: [Xen-devel] [PATCH] libxl: Do not call assert() in signal handlers

2015-10-23 Thread Ian Campbell
On Thu, 2015-10-22 at 17:22 +0100, Ian Campbell wrote: > On Thu, 2015-10-22 at 16:39 +0100, Ian Jackson wrote: > > assert is not async-signal-safe. > > I don't doubt you, but I'm curious regarding a reference. > > http://pubs.opengroup.org/onlinepubs/9699919799/functions/assert.html doe > sn > 't

Re: [Xen-devel] [PATCH] libxl: Do not call assert() in signal handlers

2015-10-22 Thread Ian Campbell
On Thu, 2015-10-22 at 16:39 +0100, Ian Jackson wrote: > assert is not async-signal-safe. I don't doubt you, but I'm curious regarding a reference. http://pubs.opengroup.org/onlinepubs/9699919799/functions/assert.html doesn 't appear to be it, unless it is too subtle for me. > In practice the eff

[Xen-devel] [PATCH] libxl: Do not call assert() in signal handlers

2015-10-22 Thread Ian Jackson
assert is not async-signal-safe. In practice the effect of calling assert there is that if the assertion fails we might get a secondary crash, or other undesirable behaviour from stdio (which is how assert usually reports failures). Mention in a comment in libxl__self_pipe_wakeup that it has to b