Re: [Xen-devel] [PATCH] libxc: move migration_stream's definition to xenguest.h

2016-03-08 Thread Wen Congyang
On 03/08/2016 06:38 PM, Andrew Cooper wrote: > On 08/03/16 05:32, Wen Congyang wrote: >> xc_save_domain()'s parameter use this type, so it should >> be public. > > xc_domain_save() currently uses an int, which also needs fixing. OK. Will fix it in the next version. > >> >> Signed-off-by: Wen Co

Re: [Xen-devel] [PATCH] libxc: move migration_stream's definition to xenguest.h

2016-03-08 Thread Andrew Cooper
On 08/03/16 05:32, Wen Congyang wrote: > xc_save_domain()'s parameter use this type, so it should > be public. xc_domain_save() currently uses an int, which also needs fixing. > > Signed-off-by: Wen Congyang Does this even compile? You have removed a variable without any replacement. > --- >

[Xen-devel] [PATCH] libxc: move migration_stream's definition to xenguest.h

2016-03-07 Thread Wen Congyang
xc_save_domain()'s parameter use this type, so it should be public. Signed-off-by: Wen Congyang --- tools/libxc/include/xenguest.h | 10 ++ tools/libxc/xc_sr_common.h | 10 -- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/libxc/include/xenguest.h b/to