Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-27 Thread Li, Liang Z
>>> patch is ok? >> >> No - Tim having confirmed that shadow mode doesn't support 1Gb pages, > the feature clearly must not be made visible for shadow mode guest. >Indeed. Liang, Can you add the shadow mode check in the next version? Ok , I will do it and resend the patch.

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-25 Thread Zhang, Yang Z
Jan Beulich wrote on 2014-11-25: On 25.11.14 at 02:47, wrote: >> Tim Deegan wrote on 2014-11-19: >>> At 01:29 + on 19 Nov (1416356943), Zhang, Yang Z wrote: Tim Deegan wrote on 2014-11-18: > In this case, the guest is entitled to _expect_ pagefaults on 1GB > mappings if CPUID

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-25 Thread Jan Beulich
>>> On 25.11.14 at 02:47, wrote: > Tim Deegan wrote on 2014-11-19: >> At 01:29 + on 19 Nov (1416356943), Zhang, Yang Z wrote: >>> Tim Deegan wrote on 2014-11-18: In this case, the guest is entitled to _expect_ pagefaults on 1GB mappings if CPUID claims they are not supported. That s

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-24 Thread Zhang, Yang Z
Tim Deegan wrote on 2014-11-19: > At 01:29 + on 19 Nov (1416356943), Zhang, Yang Z wrote: >> Tim Deegan wrote on 2014-11-18: >>> In this case, the guest is entitled to _expect_ pagefaults on 1GB >>> mappings if CPUID claims they are not supported. That sounds like >>> an unlikely thing for the

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-19 Thread Tim Deegan
At 01:29 + on 19 Nov (1416356943), Zhang, Yang Z wrote: > Tim Deegan wrote on 2014-11-18: > > In this case, the guest is entitled to _expect_ pagefaults on 1GB > > mappings if CPUID claims they are not supported. That sounds like an > > unlikely thing for the guest to be relying on, but Xen it

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-18 Thread Zhang, Yang Z
Tim Deegan wrote on 2014-11-18: > At 14:26 + on 18 Nov (1416317209), Ian Campbell wrote: >> On Tue, 2014-11-18 at 11:41 +, Zhang, Yang Z wrote: Hmm - this is a pitfall waiting to happen. In the case that there is a heterogeneous setup with one 1G capable and one 1G inca

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-18 Thread Tim Deegan
At 14:26 + on 18 Nov (1416317209), Ian Campbell wrote: > On Tue, 2014-11-18 at 11:41 +, Zhang, Yang Z wrote: > > > Hmm - this is a pitfall waiting to happen. > > > > > > In the case that there is a heterogeneous setup with one 1G capable > > > and one 1G incapable server, Xen cannot forcib

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-18 Thread Ian Campbell
On Tue, 2014-11-18 at 11:41 +, Zhang, Yang Z wrote: > > Hmm - this is a pitfall waiting to happen. > > > > In the case that there is a heterogeneous setup with one 1G capable > > and one 1G incapable server, Xen cannot forcibly prevent the use of 1G > > pages on the capable hardware. Any VM w

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-18 Thread Zhang, Yang Z
Andrew Cooper wrote on 2014-11-18: > On 18/11/14 10:14, Tim Deegan wrote: >> At 17:25 + on 17 Nov (1416241517), Andrew Cooper wrote: >>> On 17/11/14 17:00, Tim Deegan wrote: At 16:40 + on 17 Nov (1416238835), Andrew Cooper wrote: > On 17/11/14 16:30, Tim Deegan wrote: >> At 16:

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-18 Thread Andrew Cooper
On 18/11/14 10:14, Tim Deegan wrote: > At 17:25 + on 17 Nov (1416241517), Andrew Cooper wrote: >> On 17/11/14 17:00, Tim Deegan wrote: >>> At 16:40 + on 17 Nov (1416238835), Andrew Cooper wrote: On 17/11/14 16:30, Tim Deegan wrote: > At 16:24 + on 17 Nov (1416237888), Jan Beuli

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-18 Thread Tim Deegan
At 17:25 + on 17 Nov (1416241517), Andrew Cooper wrote: > On 17/11/14 17:00, Tim Deegan wrote: > > At 16:40 + on 17 Nov (1416238835), Andrew Cooper wrote: > >> On 17/11/14 16:30, Tim Deegan wrote: > >>> At 16:24 + on 17 Nov (1416237888), Jan Beulich wrote: > >>> On 17.11.14 at 16:39

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-17 Thread Andrew Cooper
On 17/11/14 17:00, Tim Deegan wrote: > At 16:40 + on 17 Nov (1416238835), Andrew Cooper wrote: >> On 17/11/14 16:30, Tim Deegan wrote: >>> At 16:24 + on 17 Nov (1416237888), Jan Beulich wrote: >>> On 17.11.14 at 16:39, wrote: > Liang Li writes ("[PATCH] libxc: Expose the pdpe1gb cp

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-17 Thread Tim Deegan
At 16:40 + on 17 Nov (1416238835), Andrew Cooper wrote: > On 17/11/14 16:30, Tim Deegan wrote: > > At 16:24 + on 17 Nov (1416237888), Jan Beulich wrote: > > On 17.11.14 at 16:39, wrote: > >>> Liang Li writes ("[PATCH] libxc: Expose the pdpe1gb cpuid flag to guest"): > If hardware

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-17 Thread Andrew Cooper
On 17/11/14 16:30, Tim Deegan wrote: > At 16:24 + on 17 Nov (1416237888), Jan Beulich wrote: > On 17.11.14 at 16:39, wrote: >>> Liang Li writes ("[PATCH] libxc: Expose the pdpe1gb cpuid flag to guest"): If hardware support the pdpe1gb flag, expose it to guest by default. Users do

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-17 Thread Tim Deegan
At 16:24 + on 17 Nov (1416237888), Jan Beulich wrote: > >>> On 17.11.14 at 16:39, wrote: > > Liang Li writes ("[PATCH] libxc: Expose the pdpe1gb cpuid flag to guest"): > >> If hardware support the pdpe1gb flag, expose it to guest by default. > >> Users don't have to use a 'cpuid= ' option in c

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-17 Thread Jan Beulich
>>> On 17.11.14 at 16:39, wrote: > Liang Li writes ("[PATCH] libxc: Expose the pdpe1gb cpuid flag to guest"): >> If hardware support the pdpe1gb flag, expose it to guest by default. >> Users don't have to use a 'cpuid= ' option in config file to turn >> it on. > > I don't understand what this fla

Re: [Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-17 Thread Ian Jackson
Liang Li writes ("[PATCH] libxc: Expose the pdpe1gb cpuid flag to guest"): > If hardware support the pdpe1gb flag, expose it to guest by default. > Users don't have to use a 'cpuid= ' option in config file to turn > it on. I don't understand what this flag does. I guess from the name it turns on

[Xen-devel] [PATCH] libxc: Expose the pdpe1gb cpuid flag to guest

2014-11-16 Thread Liang Li
If hardware support the pdpe1gb flag, expose it to guest by default. Users don't have to use a 'cpuid= ' option in config file to turn it on. Signed-off-by: Liang Li --- tools/libxc/xc_cpuid_x86.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_