Re: [Xen-devel] [PATCH] libxc/x86: XSAVE related adjustments

2016-03-23 Thread Jan Beulich
>>> On 22.03.16 at 18:23, wrote: > On 22/03/16 14:46, Jan Beulich wrote: > On 22.03.16 at 14:48, wrote: @@ -300,9 +304,9 @@ static void xc_cpuid_config_xsave(xc_int { case 0: /* EAX: low 32bits of xfeature_enabled_mask */ -regs[0] = info->x

Re: [Xen-devel] [PATCH] libxc/x86: XSAVE related adjustments

2016-03-22 Thread Andrew Cooper
On 22/03/16 14:46, Jan Beulich wrote: On 22.03.16 at 14:48, wrote: >>> @@ -300,9 +304,9 @@ static void xc_cpuid_config_xsave(xc_int >>> { >>> case 0: >>> /* EAX: low 32bits of xfeature_enabled_mask */ >>> -regs[0] = info->xfeature_mask & 0x; >>> +re

Re: [Xen-devel] [PATCH] libxc/x86: XSAVE related adjustments

2016-03-22 Thread Jan Beulich
>>> On 22.03.16 at 14:48, wrote: >> @@ -300,9 +304,9 @@ static void xc_cpuid_config_xsave(xc_int >> { >> case 0: >> /* EAX: low 32bits of xfeature_enabled_mask */ >> -regs[0] = info->xfeature_mask & 0x; >> +regs[0] &= info->xfeature_mask; >> /*

Re: [Xen-devel] [PATCH] libxc/x86: XSAVE related adjustments

2016-03-22 Thread Andrew Cooper
On 22/03/16 13:05, Jan Beulich wrote: > - don't unintentionally increase features reported by sub-leaf 0 > EDX:EAX > - don't discard the known flags in sub-leaves 2..63 ECX > - handle components 32...62 (EDX) in sub-leaf 1 consistently with > 0...31 (ECX) > - zap sub-leaves beyond 62 > > Signed

[Xen-devel] [PATCH] libxc/x86: XSAVE related adjustments

2016-03-22 Thread Jan Beulich
- don't unintentionally increase features reported by sub-leaf 0 EDX:EAX - don't discard the known flags in sub-leaves 2..63 ECX - handle components 32...62 (EDX) in sub-leaf 1 consistently with 0...31 (ECX) - zap sub-leaves beyond 62 Signed-off-by: Jan Beulich --- While obviously requiring r