Re: [Xen-devel] [PATCH] libvchan: address compiler warnings

2015-02-05 Thread Ian Campbell
On Wed, 2015-02-04 at 16:26 +, Wei Liu wrote: > On Wed, Feb 04, 2015 at 04:07:48PM +, Jan Beulich wrote: > > Both vchan_wr() and stdout_wr() should be defined with a non-empty > > argument list (i.e. void). Additionally both of them as well as usage() > > should be static to make clear that

Re: [Xen-devel] [PATCH] libvchan: address compiler warnings

2015-02-04 Thread Wei Liu
On Wed, Feb 04, 2015 at 04:07:48PM +, Jan Beulich wrote: > Both vchan_wr() and stdout_wr() should be defined with a non-empty > argument list (i.e. void). Additionally both of them as well as usage() > should be static to make clear that no other code is referencing them. > > Further, statemen

[Xen-devel] [PATCH] libvchan: address compiler warnings

2015-02-04 Thread Jan Beulich
Both vchan_wr() and stdout_wr() should be defined with a non-empty argument list (i.e. void). Additionally both of them as well as usage() should be static to make clear that no other code is referencing them. Further, statements should follow declarations. Signed-off-by: Jan Beulich --- a/tool