Re: [Xen-devel] [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined

2015-07-23 Thread Andrew Cooper
On 22/07/15 15:38, Jan Beulich wrote: > This being an in-guest component, it shouldn't get to see (and even > less so use) tools-only public interfaces. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/tools/firmware/hvmloader/Makefile > +++ b/tools/firmware/hvmloader/Makefil

Re: [Xen-devel] [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined

2015-07-23 Thread Ian Campbell
On Wed, 2015-07-22 at 08:38 -0600, Jan Beulich wrote: > This being an in-guest component, it shouldn't get to see (and even > less so use) tools-only public interfaces. > > Signed-off-by: Jan Beulich FWIW: Acked-by: Ian Campbell > > --- a/tools/firmware/hvmloader/Makefile > +++ b/tools/firmwa

[Xen-devel] [PATCH] hvmloader: don't build with __XEN_TOOLS__ defined

2015-07-22 Thread Jan Beulich
This being an in-guest component, it shouldn't get to see (and even less so use) tools-only public interfaces. Signed-off-by: Jan Beulich --- a/tools/firmware/hvmloader/Makefile +++ b/tools/firmware/hvmloader/Makefile @@ -31,6 +31,9 @@ SMBIOS_REL_DATE ?= $(shell date +%m/%d/% CFLAGS += $(CFLA