Re: [Xen-devel] [PATCH] hvmloader: cast to avoid potential overflow in shadow_gs_test

2017-09-12 Thread Wei Liu
On Mon, Sep 11, 2017 at 09:20:58AM -0600, Jan Beulich wrote: > >>> On 11.09.17 at 17:01, wrote: > > On Mon, Sep 11, 2017 at 08:55:53AM -0600, Jan Beulich wrote: > >> >>> On 11.09.17 at 16:07, wrote: > >> > e2fc5bb5cb4 ("hvmloader: dynamically determine scratch memory range > >> > for tests") make

Re: [Xen-devel] [PATCH] hvmloader: cast to avoid potential overflow in shadow_gs_test

2017-09-11 Thread Jan Beulich
>>> On 11.09.17 at 17:01, wrote: > On Mon, Sep 11, 2017 at 08:55:53AM -0600, Jan Beulich wrote: >> >>> On 11.09.17 at 16:07, wrote: >> > e2fc5bb5cb4 ("hvmloader: dynamically determine scratch memory range >> > for tests") makes the test dependent on _end. Coverity reported that >> > the shift mig

Re: [Xen-devel] [PATCH] hvmloader: cast to avoid potential overflow in shadow_gs_test

2017-09-11 Thread Wei Liu
On Mon, Sep 11, 2017 at 08:55:53AM -0600, Jan Beulich wrote: > >>> On 11.09.17 at 16:07, wrote: > > e2fc5bb5cb4 ("hvmloader: dynamically determine scratch memory range > > for tests") makes the test dependent on _end. Coverity reported that > > the shift might overflow and suggested we cast i to u

Re: [Xen-devel] [PATCH] hvmloader: cast to avoid potential overflow in shadow_gs_test

2017-09-11 Thread Jan Beulich
>>> On 11.09.17 at 16:07, wrote: > e2fc5bb5cb4 ("hvmloader: dynamically determine scratch memory range > for tests") makes the test dependent on _end. Coverity reported that > the shift might overflow and suggested we cast i to uint64_t. > > Coverity-ID: 1417660 > > Signed-off-by: Wei Liu > ---

[Xen-devel] [PATCH] hvmloader: cast to avoid potential overflow in shadow_gs_test

2017-09-11 Thread Wei Liu
e2fc5bb5cb4 ("hvmloader: dynamically determine scratch memory range for tests") makes the test dependent on _end. Coverity reported that the shift might overflow and suggested we cast i to uint64_t. Coverity-ID: 1417660 Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper --- tools/fi