Re: [Xen-devel] [PATCH] hvm/vmx: WRITE_MSR() macro hygene

2015-01-08 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, January 08, 2015 11:39 PM > > Use the standard "do { } while ( 0 )" semantics, and don't hide the break > statement, incase this macro wants to be used anywhere outside of a switch. > > No functional change, but it is now

Re: [Xen-devel] [PATCH] hvm/vmx: WRITE_MSR() macro hygene

2015-01-08 Thread Tim Deegan
At 15:38 + on 08 Jan (1420727918), Andrew Cooper wrote: > Use the standard "do { } while ( 0 )" semantics, and don't hide the break > statement, incase this macro wants to be used anywhere outside of a switch. > > No functional change, but it is now clear that long_mode_do_msr_write() > doesn'

[Xen-devel] [PATCH] hvm/vmx: WRITE_MSR() macro hygene

2015-01-08 Thread Andrew Cooper
Use the standard "do { } while ( 0 )" semantics, and don't hide the break statement, incase this macro wants to be used anywhere outside of a switch. No functional change, but it is now clear that long_mode_do_msr_write() doesn't have fallthough for the STAR, LSTAR and SYSCALL_MASK cases. Signed-