Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Chun Yan Liu
>>> On 11/17/2014 at 11:45 PM, in message <21610.6141.943750.141...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH] fix rename: xenstore not fully updated"): > > Currently libxl__domain_rename only update /local/domain//name, > > still some places in xenstore are

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Chun Yan Liu
>>> On 11/17/2014 at 11:53 PM, in message <1416239594.5466.23.ca...@citrix.com>, Ian Campbell wrote: > On Mon, 2014-11-17 at 15:45 +, Ian Jackson wrote: > > > +/* update backend > > > /local/domain/0/backend///.../domain */ > > > > Um, what on earth creates that ? > > > > Worse,

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Ian Campbell
On Mon, 2014-11-17 at 15:45 +, Ian Jackson wrote: > > +/* update backend /local/domain/0/backend///.../domain > > */ > > Um, what on earth creates that ? > > Worse, what reads it ? > > I think that putting this information in the backend directory is > entirely wrong. I concluded the s

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Ian Jackson
Chunyan Liu writes ("[PATCH] fix rename: xenstore not fully updated"): > Currently libxl__domain_rename only update /local/domain//name, > still some places in xenstore are not updated, including: > /vm//name and /local/domain/0/backend///.../domain. Thanks. ... > +/* update /vm//name */ > +

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Ian Campbell
On Mon, 2014-11-17 at 10:48 +, Wei Liu wrote: > On Mon, Nov 17, 2014 at 10:42:45AM +, Ian Campbell wrote: > > On Mon, 2014-11-17 at 10:41 +, Wei Liu wrote: > > > On Mon, Nov 17, 2014 at 10:25:31AM +, Ian Campbell wrote: > > > > On Mon, 2014-11-17 at 09:52 +, Wei Liu wrote: > > >

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Ian Campbell
On Mon, 2014-11-17 at 10:42 +, Ian Campbell wrote: > On Mon, 2014-11-17 at 10:41 +, Wei Liu wrote: > > On Mon, Nov 17, 2014 at 10:25:31AM +, Ian Campbell wrote: > > > On Mon, 2014-11-17 at 09:52 +, Wei Liu wrote: > > > > > +/* update backend > > > > > /local/domain/0/backend///

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Wei Liu
On Mon, Nov 17, 2014 at 10:42:45AM +, Ian Campbell wrote: > On Mon, 2014-11-17 at 10:41 +, Wei Liu wrote: > > On Mon, Nov 17, 2014 at 10:25:31AM +, Ian Campbell wrote: > > > On Mon, 2014-11-17 at 09:52 +, Wei Liu wrote: > > > > > +/* update backend > > > > > /local/domain/0/bac

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Ian Campbell
On Mon, 2014-11-17 at 10:41 +, Wei Liu wrote: > On Mon, Nov 17, 2014 at 10:25:31AM +, Ian Campbell wrote: > > On Mon, 2014-11-17 at 09:52 +, Wei Liu wrote: > > > > +/* update backend > > > > /local/domain/0/backend///.../domain */ > > > > +be_dev = libxl__xs_directory(gc, trans

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Wei Liu
On Mon, Nov 17, 2014 at 10:25:31AM +, Ian Campbell wrote: > On Mon, 2014-11-17 at 09:52 +, Wei Liu wrote: > > > +/* update backend > > > /local/domain/0/backend///.../domain */ > > > +be_dev = libxl__xs_directory(gc, trans, "/local/domain/0/backend", > > > &ndevs); > > > > The ha

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Ian Campbell
On Mon, 2014-11-17 at 09:52 +, Wei Liu wrote: > > +/* update backend /local/domain/0/backend///.../domain > > */ > > +be_dev = libxl__xs_directory(gc, trans, "/local/domain/0/backend", > > &ndevs); > > The hard-coded 0 cannot work if you have driver domain. > > At the very least it

Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Wei Liu
Is this a regression? Can it wait until 4.6? On Mon, Nov 17, 2014 at 05:19:47PM +0800, Chunyan Liu wrote: > Currently libxl__domain_rename only update /local/domain//name, > still some places in xenstore are not updated, including: > /vm//name and /local/domain/0/backend///.../domain. > I notice

[Xen-devel] [PATCH] fix rename: xenstore not fully updated

2014-11-17 Thread Chunyan Liu
Currently libxl__domain_rename only update /local/domain//name, still some places in xenstore are not updated, including: /vm//name and /local/domain/0/backend///.../domain. Signed-off-by: Chunyan Liu --- tools/libxl/libxl.c | 55 + 1 file chan