Re: [Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 18:31, wrote: > Jan Beulich writes ("[PATCH] domctl: relax getdomaininfo permissions"): >> Qemu needs access to this for the domain it controls, both due to it >> being used by xc_domain_memory_mapping() (which qemu calls) and the >> explicit use in hw/xenpv/xen_domainbuild.c:xe

Re: [Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Andrew Cooper
On 04/08/16 17:07, Jan Beulich wrote: On 04.08.16 at 17:55, wrote: >> On 04/08/16 16:44, Jan Beulich wrote: >> On 04.08.16 at 17:22, wrote: On 04/08/16 09:41, Jan Beulich wrote: > @@ -817,14 +816,22 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe > > case XEN_DOMCTL_g

Re: [Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Ian Jackson
Jan Beulich writes ("[PATCH] domctl: relax getdomaininfo permissions"): > Qemu needs access to this for the domain it controls, both due to it > being used by xc_domain_memory_mapping() (which qemu calls) and the > explicit use in hw/xenpv/xen_domainbuild.c:xen_domain_poll(). > > This at once avoi

Re: [Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 17:55, wrote: > On 04/08/16 16:44, Jan Beulich wrote: > On 04.08.16 at 17:22, wrote: >>> On 04/08/16 09:41, Jan Beulich wrote: @@ -817,14 +816,22 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe case XEN_DOMCTL_getdomaininfo: { -domid

Re: [Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Andrew Cooper
On 04/08/16 16:44, Jan Beulich wrote: On 04.08.16 at 17:22, wrote: >> On 04/08/16 09:41, Jan Beulich wrote: >>> @@ -817,14 +816,22 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe >>> >>> case XEN_DOMCTL_getdomaininfo: >>> { >>> -domid_t dom = op->domain; >>> - >>> -rcu

Re: [Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Jan Beulich
>>> On 04.08.16 at 17:22, wrote: > On 04/08/16 09:41, Jan Beulich wrote: >> @@ -817,14 +816,22 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xe >> >> case XEN_DOMCTL_getdomaininfo: >> { >> -domid_t dom = op->domain; >> - >> -rcu_read_lock(&domlist_read_lock); >> +dom

Re: [Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Andrew Cooper
On 04/08/16 09:41, Jan Beulich wrote: > Qemu needs access to this for the domain it controls, both due to it > being used by xc_domain_memory_mapping() (which qemu calls) and the > explicit use in hw/xenpv/xen_domainbuild.c:xen_domain_poll(). > > This at once avoids a for_each_domain() loop when th

[Xen-devel] [PATCH] domctl: relax getdomaininfo permissions

2016-08-04 Thread Jan Beulich
Qemu needs access to this for the domain it controls, both due to it being used by xc_domain_memory_mapping() (which qemu calls) and the explicit use in hw/xenpv/xen_domainbuild.c:xen_domain_poll(). This at once avoids a for_each_domain() loop when the ID of an existing domain gets passed in. Rep