Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-27 Thread Tamas K Lengyel
On Tue, Jun 27, 2017 at 8:25 AM, Razvan Cojocaru wrote: > On 06/27/2017 02:45 PM, Jan Beulich wrote: > Razvan Cojocaru 06/27/17 1:38 PM >>> >>> On 06/27/2017 02:26 PM, Jan Beulich wrote: >>> Razvan Cojocaru 06/27/17 10:32 AM >>> > On 06/27/2017 09:21 AM, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-27 Thread Razvan Cojocaru
On 06/27/2017 02:45 PM, Jan Beulich wrote: Razvan Cojocaru 06/27/17 1:38 PM >>> >> On 06/27/2017 02:26 PM, Jan Beulich wrote: >> Razvan Cojocaru 06/27/17 10:32 AM >>> On 06/27/2017 09:21 AM, Jan Beulich wrote: Andrew Cooper 06/26/17 5:11 PM >>> >> There is also a diffe

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-27 Thread Jan Beulich
>>> Razvan Cojocaru 06/27/17 1:38 PM >>> >On 06/27/2017 02:26 PM, Jan Beulich wrote: > Razvan Cojocaru 06/27/17 10:32 AM >>> >>> On 06/27/2017 09:21 AM, Jan Beulich wrote: >>> Andrew Cooper 06/26/17 5:11 PM >>> > There is also a difference in timing; vm_event_init_domain() is called

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-27 Thread Razvan Cojocaru
On 06/27/2017 02:26 PM, Jan Beulich wrote: Razvan Cojocaru 06/27/17 10:32 AM >>> >> On 06/27/2017 09:21 AM, Jan Beulich wrote: >> Andrew Cooper 06/26/17 5:11 PM >>> There is also a difference in timing; vm_event_init_domain() is called when vm_event is started on the domain, no

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-27 Thread Jan Beulich
>>> Razvan Cojocaru 06/27/17 10:32 AM >>> >On 06/27/2017 09:21 AM, Jan Beulich wrote: > Andrew Cooper 06/26/17 5:11 PM >>> >>> There is also a difference in timing; vm_event_init_domain() is called >>> when vm_event is started on the domain, not when the domain is >>> constructed. IMO, the t

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-27 Thread Razvan Cojocaru
On 06/27/2017 09:21 AM, Jan Beulich wrote: Andrew Cooper 06/26/17 5:11 PM >>> >> There is also a difference in timing; vm_event_init_domain() is called >> when vm_event is started on the domain, not when the domain is >> constructed. IMO, the two should happen at the same time to be >> consi

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Jan Beulich
>>> Andrew Cooper 06/26/17 5:11 PM >>> >There is also a difference in timing; vm_event_init_domain() is called >when vm_event is started on the domain, not when the domain is >constructed. IMO, the two should happen at the same time to be >consistent. I'm not fussed at which point, as it would b

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Tamas K Lengyel
On Mon, Jun 26, 2017 at 9:09 AM, Andrew Cooper wrote: > On 26/06/17 15:52, Tamas K Lengyel wrote: >> On Mon, Jun 26, 2017 at 3:48 AM, Razvan Cojocaru >> wrote: >>> Pending livepatch code wants to check if the vm_event wait queues >>> are active, and this is made harder by the fact that they were

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Andrew Cooper
On 26/06/17 15:52, Tamas K Lengyel wrote: > On Mon, Jun 26, 2017 at 3:48 AM, Razvan Cojocaru > wrote: >> Pending livepatch code wants to check if the vm_event wait queues >> are active, and this is made harder by the fact that they were >> previously only initialized some time after the domain was

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Tamas K Lengyel
On Mon, Jun 26, 2017 at 3:48 AM, Razvan Cojocaru wrote: > Pending livepatch code wants to check if the vm_event wait queues > are active, and this is made harder by the fact that they were > previously only initialized some time after the domain was created, > in vm_event_enable(). This patch init

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Razvan Cojocaru
On 06/26/2017 03:14 PM, Andrew Cooper wrote: > Razvan: I'd reword this to not mention livepatching. Simply having > list_empty() working is a good enough reason alone. Fair enough, I'll change the patch description as soon as we hear from Tamas, so that I might address as many comments as possibl

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Andrew Cooper
On 26/06/17 12:39, Konrad Rzeszutek Wilk wrote: > On June 26, 2017 5:48:17 AM EDT, Razvan Cojocaru > wrote: >> Pending livepatch code wants to check if the vm_event wait queues >> are active, and this is made harder by the fact that they were > > Hmm, it wants to? Is there an missing patch that h

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Razvan Cojocaru
On 06/26/2017 02:39 PM, Konrad Rzeszutek Wilk wrote: > On June 26, 2017 5:48:17 AM EDT, Razvan Cojocaru > wrote: >> Pending livepatch code wants to check if the vm_event wait queues >> are active, and this is made harder by the fact that they were > > > Hmm, it wants to? Is there an missing pat

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Konrad Rzeszutek Wilk
On June 26, 2017 5:48:17 AM EDT, Razvan Cojocaru wrote: >Pending livepatch code wants to check if the vm_event wait queues >are active, and this is made harder by the fact that they were Hmm, it wants to? Is there an missing patch that hasn't been posted for this? If you mean to post this _bef

[Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Razvan Cojocaru
Pending livepatch code wants to check if the vm_event wait queues are active, and this is made harder by the fact that they were previously only initialized some time after the domain was created, in vm_event_enable(). This patch initializes the lists immediately after xzalloc()ating the vm_event m