Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2016-01-21 Thread Rasmus Villemoes
On Wed, Jan 20 2016, Konrad Rzeszutek Wilk wrote: > On Wed, Dec 23, 2015 at 10:06:24PM +0100, Julia Lawall wrote: >> The cleancache_ops structure is never modified, so declare it as const. >> >> This also removes the __read_mostly declaration on the cleancache_ops >> variable declaration, since

Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2016-01-21 Thread Julia Lawall
On Thu, 21 Jan 2016, Rasmus Villemoes wrote: > On Wed, Jan 20 2016, Konrad Rzeszutek Wilk wrote: > > > On Wed, Dec 23, 2015 at 10:06:24PM +0100, Julia Lawall wrote: > >> The cleancache_ops structure is never modified, so declare it as const. > >> > >> This also removes the __read_mostly decla

Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2016-01-21 Thread Julia Lawall
On Thu, 21 Jan 2016, David Vrabel wrote: > On 23/12/15 21:06, Julia Lawall wrote: > > The cleancache_ops structure is never modified, so declare it as const. > > > > This also removes the __read_mostly declaration on the cleancache_ops > > variable declaration, since it seems redundant with cons

Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2016-01-21 Thread David Vrabel
On 23/12/15 21:06, Julia Lawall wrote: > The cleancache_ops structure is never modified, so declare it as const. > > This also removes the __read_mostly declaration on the cleancache_ops > variable declaration, since it seems redundant with const. > > Done with the help of Coccinelle. > > Signed

Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2016-01-20 Thread Konrad Rzeszutek Wilk
On Wed, Dec 23, 2015 at 10:06:24PM +0100, Julia Lawall wrote: > The cleancache_ops structure is never modified, so declare it as const. > > This also removes the __read_mostly declaration on the cleancache_ops > variable declaration, since it seems redundant with const. > > Done with the help of

[Xen-devel] [PATCH] cleancache: constify cleancache_ops structure

2015-12-23 Thread Julia Lawall
The cleancache_ops structure is never modified, so declare it as const. This also removes the __read_mostly declaration on the cleancache_ops variable declaration, since it seems redundant with const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- Not sure that the __read_m