Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-21 Thread Igor Druzhinin
On 09/11/17 14:49, Jan Beulich wrote: > See the code comment being added for why we need this. > > Reported-by: Igor Druzhinin > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -479,7 +479,13 @@ static void vmx_vcpu_destroy(struct vcpu >

Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-13 Thread Jan Beulich
>>> On 10.11.17 at 15:46, wrote: > On 10/11/17 10:30, Jan Beulich wrote: > On 10.11.17 at 09:41, wrote: >>>2. Drop v->is_running check inside vmx_ctxt_switch_from() making >>>vmx_vmcs_reload() unconditional. >> >> This is an option, indeed (and I don't think it would have a >> me

Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-10 Thread Igor Druzhinin
On 10/11/17 10:30, Jan Beulich wrote: On 10.11.17 at 09:41, wrote: >> On Thu, 2017-11-09 at 07:49 -0700, Jan Beulich wrote: >>> --- a/xen/arch/x86/hvm/vmx/vmx.c >>> +++ b/xen/arch/x86/hvm/vmx/vmx.c >>> @@ -479,7 +479,13 @@ static void vmx_vcpu_destroy(struct vcpu >>> * we should disable

Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-10 Thread Jan Beulich
>>> On 10.11.17 at 09:41, wrote: > On Thu, 2017-11-09 at 07:49 -0700, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -479,7 +479,13 @@ static void vmx_vcpu_destroy(struct vcpu >> * we should disable PML manually here. Note that vmx_vcpu_destr

Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-10 Thread Dario Faggioli
On Fri, 2017-11-10 at 08:41 +, Sergey Dyasli wrote: > On Thu, 2017-11-09 at 07:49 -0700, Jan Beulich wrote: > > > This patch fixes only one particular issue and not the general > problem. > What if vmcs is cleared, possibly in some future code, at another > place? > Yes, that's what we were s

Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-10 Thread Sergey Dyasli
On Thu, 2017-11-09 at 07:49 -0700, Jan Beulich wrote: > See the code comment being added for why we need this. > > Reported-by: Igor Druzhinin > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -479,7 +479,13 @@ static void vmx_vcpu_destroy

Re: [Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-09 Thread Dario Faggioli
On Thu, 2017-11-09 at 07:49 -0700, Jan Beulich wrote: > See the code comment being added for why we need this. > > Reported-by: Igor Druzhinin > Signed-off-by: Jan Beulich > Reviewed-by: Dario Faggioli Regards, Dario -- <> (Raistlin Majere) ---

[Xen-devel] [PATCH] VMX: sync CPU state upon vCPU destruction

2017-11-09 Thread Jan Beulich
See the code comment being added for why we need this. Reported-by: Igor Druzhinin Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -479,7 +479,13 @@ static void vmx_vcpu_destroy(struct vcpu * we should disable PML manually here. Note that vm