Re: [Xen-devel] [PATCH] RFC x86/emul: Drop segment_attributes_t

2017-06-07 Thread Jan Beulich
>>> On 07.06.17 at 17:44, wrote: > On 07/06/17 14:40, Jan Beulich wrote: > On 07.06.17 at 15:04, wrote: >>> Furthermore, in a following patch, I intend to make a similar adjustment as >>> http://xenbits.xen.org/gitweb/?p=xtf.git;a=commitdiff;h=f099211f2ebdadf61ae6 >>> >>> 416559220d69b788cd

Re: [Xen-devel] [PATCH] RFC x86/emul: Drop segment_attributes_t

2017-06-07 Thread Andrew Cooper
On 07/06/17 14:40, Jan Beulich wrote: On 07.06.17 at 15:04, wrote: >> RFC, because I'd also like to float the idea of making this adjustment as >> well: >> >> diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h >> b/xen/arch/x86/x86_emulate/x86_emulate.h >> index 3355c01..53a5480 100644 >>

Re: [Xen-devel] [PATCH] RFC x86/emul: Drop segment_attributes_t

2017-06-07 Thread Jan Beulich
>>> On 07.06.17 at 15:04, wrote: > RFC, because I'd also like to float the idea of making this adjustment as > well: > > diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h > b/xen/arch/x86/x86_emulate/x86_emulate.h > index 3355c01..53a5480 100644 > --- a/xen/arch/x86/x86_emulate/x86_emulate.h

[Xen-devel] [PATCH] RFC x86/emul: Drop segment_attributes_t

2017-06-07 Thread Andrew Cooper
The amount of namespace resolution is unnecessrily large, as all code deals in terms of struct segment_register. This removes the .fields part of all references, and alters .bytes for .raw. No functional change. For some reason I can't identify, the changes to {rm,vm86}_{cs,ds}_attr causes GCC t