Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-05 Thread Wei Liu
On Wed, Apr 05, 2017 at 02:58:48PM +0300, Razvan Cojocaru wrote: > > > > > As its current user is only for debugging, I think this functional fix > > as proposed is fine, as long as it also adds a comment at the top > > indicating that the use of this function is hazardous for your health in > >

Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-05 Thread Razvan Cojocaru
On 04/04/2017 08:04 PM, Andrew Cooper wrote: > On 04/04/17 17:45, Razvan Cojocaru wrote: >> On 04/04/2017 07:08 PM, Tamas K Lengyel wrote: >>> >>> On Tue, Apr 4, 2017 at 9:58 AM, Andrew Cooper >> > wrote: >>> >>> On 04/04/17 16:39, Tamas K Lengyel wrote: >

Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-04 Thread Andrew Cooper
On 04/04/17 17:45, Razvan Cojocaru wrote: > On 04/04/2017 07:08 PM, Tamas K Lengyel wrote: >> >> On Tue, Apr 4, 2017 at 9:58 AM, Andrew Cooper > > wrote: >> >> On 04/04/17 16:39, Tamas K Lengyel wrote: >>> >>> On Tue, Apr 4, 2017 at 9:11 AM, Andrew Cooper >

Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-04 Thread Razvan Cojocaru
On 04/04/2017 07:08 PM, Tamas K Lengyel wrote: > > > On Tue, Apr 4, 2017 at 9:58 AM, Andrew Cooper > wrote: > > On 04/04/17 16:39, Tamas K Lengyel wrote: >> >> >> On Tue, Apr 4, 2017 at 9:11 AM, Andrew Cooper >> mailto:andrew.coop...@citrix.com>> wr

Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-04 Thread Tamas K Lengyel
On Tue, Apr 4, 2017 at 9:58 AM, Andrew Cooper wrote: > On 04/04/17 16:39, Tamas K Lengyel wrote: > > > > On Tue, Apr 4, 2017 at 9:11 AM, Andrew Cooper > wrote: > >> On 04/04/17 13:14, Razvan Cojocaru wrote: >> > Currently xc_translate_foreign_address only checks for PSE bit only on >> > level 2

Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-04 Thread Andrew Cooper
On 04/04/17 16:39, Tamas K Lengyel wrote: > > > On Tue, Apr 4, 2017 at 9:11 AM, Andrew Cooper > mailto:andrew.coop...@citrix.com>> wrote: > > On 04/04/17 13:14, Razvan Cojocaru wrote: > > Currently xc_translate_foreign_address only checks for PSE bit > only on > > level 2 entries (t

Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-04 Thread Tamas K Lengyel
On Tue, Apr 4, 2017 at 9:11 AM, Andrew Cooper wrote: > On 04/04/17 13:14, Razvan Cojocaru wrote: > > Currently xc_translate_foreign_address only checks for PSE bit only on > > level 2 entries (that's 2 MB pages on x64 and 32-bit with PAE, and 4 MB > > pages on 32-bit). But linux kernel sometimes

Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-04 Thread Razvan Cojocaru
On 04/04/2017 06:11 PM, Andrew Cooper wrote: > On 04/04/17 13:14, Razvan Cojocaru wrote: >> Currently xc_translate_foreign_address only checks for PSE bit only on >> level 2 entries (that's 2 MB pages on x64 and 32-bit with PAE, and 4 MB >> pages on 32-bit). But linux kernel sometimes uses 1 GB pag

Re: [Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-04 Thread Andrew Cooper
On 04/04/17 13:14, Razvan Cojocaru wrote: > Currently xc_translate_foreign_address only checks for PSE bit only on > level 2 entries (that's 2 MB pages on x64 and 32-bit with PAE, and 4 MB > pages on 32-bit). But linux kernel sometimes uses 1 GB pages. This patch > fixes that, and checks the PSE bi

[Xen-devel] [PATCH] Libxc: fix xc_translate_foreign_address()

2017-04-04 Thread Razvan Cojocaru
Currently xc_translate_foreign_address only checks for PSE bit only on level 2 entries (that's 2 MB pages on x64 and 32-bit with PAE, and 4 MB pages on 32-bit). But linux kernel sometimes uses 1 GB pages. This patch fixes that, and checks the PSE bit on level 3 entries if the guest has 4 translatio