Re: [Xen-devel] [PATCH] Fix building error

2015-01-15 Thread Wen Congyang
On 01/15/2015 05:21 PM, Olaf Hering wrote: > On Thu, Jan 15, Wen Congyang wrote: > >> Xen doesn't use the macro _FORTIFY_SOURCE, so it only affects python >> modules now. > > It does if it is passed via global CFLAGS, like the RPM_OPT_FLAGS from a > rpm package build. Yes, I don't consider such

Re: [Xen-devel] [PATCH] Fix building error

2015-01-15 Thread Olaf Hering
On Thu, Jan 15, Wen Congyang wrote: > Xen doesn't use the macro _FORTIFY_SOURCE, so it only affects python > modules now. It does if it is passed via global CFLAGS, like the RPM_OPT_FLAGS from a rpm package build. Olaf ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] [PATCH] Fix building error

2015-01-15 Thread Wen Congyang
On 01/15/2015 03:57 PM, Olaf Hering wrote: > On Thu, Jan 15, Wen Congyang wrote: > >> Commit 1166ecf7 disables optimization. But python's build >> process may use CFLAGS -Wp,-D_FORTIFY_SOURCE=2, and suppose >> the 3rd party python modules to use. The macro _FORTIFY_SOURCE >> requires compiling wit

Re: [Xen-devel] [PATCH] Fix building error

2015-01-14 Thread Olaf Hering
On Thu, Jan 15, Wen Congyang wrote: > Commit 1166ecf7 disables optimization. But python's build > process may use CFLAGS -Wp,-D_FORTIFY_SOURCE=2, and suppose > the 3rd party python modules to use. The macro _FORTIFY_SOURCE > requires compiling with optimization (-O). Disable _FORTIFY_SOURCE > by a

[Xen-devel] [PATCH] Fix building error

2015-01-14 Thread Wen Congyang
Commit 1166ecf7 disables optimization. But python's build process may use CFLAGS -Wp,-D_FORTIFY_SOURCE=2, and suppose the 3rd party python modules to use. The macro _FORTIFY_SOURCE requires compiling with optimization (-O). Disable _FORTIFY_SOURCE by appending -Wp,-U_FORTIFY_SOURCE to CFLAGS. Sign