Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-11 Thread Ian Campbell
On Fri, 2015-12-11 at 15:34 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database > schema updates"): > > On Fri, 2015-12-11 at 15:15 +, Ian Jackson wrote: > > > I can put this in a comment if you like. > > > > I suppose a comment next to any such o

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-11 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database schema updates"): > On Fri, 2015-12-11 at 15:15 +, Ian Jackson wrote: > > I can put this in a comment if you like. > > I suppose a comment next to any such override is a pretty good policy to > have. OK. See below; I hav

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-11 Thread Ian Campbell
On Fri, 2015-12-11 at 15:15 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database > schema updates"): > > On Thu, 2015-12-10 at 18:27 +, Ian Jackson wrote: > > > See schema/README.schema, introduced in this patch, for the design. > > > > The README

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-11 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database schema updates"): > On Thu, 2015-12-10 at 18:27 +, Ian Jackson wrote: > > See schema/README.schema, introduced in this patch, for the design. > > The README looks good now, thanks. Thanks. > Code comments > > diff -

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-11 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database schema updates"): > On Thu, 2015-12-10 at 18:00 +, Ian Jackson wrote: > > It does say that updates are applied in order. > > Right I was considering an osstest repo with 01 and 03 in it, which is > applied and all up to da

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-11 Thread Ian Campbell
On Thu, 2015-12-10 at 18:27 +, Ian Jackson wrote: > Ian Jackson writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database > schema updates"): > > It does say that updates are applied in order.  I will add `and > > monotonically increasing' after `unique'.  [etc etc] > > Here is v3 of this patc

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-11 Thread Ian Campbell
On Thu, 2015-12-10 at 18:00 +, Ian Jackson wrote: > Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database > schema updates"): > > On Thu, 2015-12-10 at 17:12 +, Ian Jackson wrote: > > > + is a positive integer, which should be unique.  Updates > > > are > > > +applied in or

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-10 Thread Ian Jackson
Ian Jackson writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database schema updates"): > It does say that updates are applied in order. I will add `and > monotonically increasing' after `unique'. [etc etc] Here is v3 of this patch. I'll refrain from reposting the whole series. Ian. >From a7

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-10 Thread Ian Jackson
Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database schema updates"): > On Thu, 2015-12-10 at 17:12 +, Ian Jackson wrote: > > + is a positive integer, which should be unique.  Updates are > > +applied in order. > > Don't these also need to be monotonically increasing over t

Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-10 Thread Ian Campbell
On Thu, 2015-12-10 at 17:12 +, Ian Jackson wrote: > diff --git a/schema/README.updates b/schema/README.updates > new file mode 100644 > index 000..622410c > --- /dev/null > +++ b/schema/README.updates > @@ -0,0 +1,179 @@ > +SCHEMA DEFINITION AND SCHEMA UPDATES (PRODUCTION `EXECUTIVE' MODE)

[Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

2015-12-10 Thread Ian Jackson
See schema/README.schema, introduced in this patch, for the design. Signed-off-by: Ian Jackson --- v2: Slight increase schema update name length format. Docs fixes: Change erroneous `three' to `four'. Change `state' to `status' throghout. Explain scope of . Sort out (and renum